From: Cyril Hrubis <chrubis@suse.cz>
To: Sebastian Chlad <sebastianchlad@gmail.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] lib: tst_device: Scale loop device detach timeout
Date: Thu, 22 Oct 2026 15:09:42 +0200 [thread overview]
Message-ID: <atoLFrOnClQt2UuL@yuki.lan> (raw)
In-Reply-To: <atoKordoJ70aqMHk@yuki.lan>
Hi!
> > Scale the number of retries with tst_multiply_timeout(), which attach
> > already uses since d90d20046 ("lib: Use backoff polling to wait for
> > loop device nodes"). The default stays 2s, multiplied by 4 on kernels
> > with slow kconfig options and by LTP_TIMEOUT_MUL. The 50ms polling
> > step is kept, so the detach still finishes shortly after the device
> > is released.
>
> It would probably be better if we used the TST_RETRY_FN_EXP_BACKOFF() in
> the detach loop instead so that the deatch is fast on fast device but we
> do not poll unecessairly fast on slow devices.
And that macro already scales the timeout with tst_multiply_timeout().
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-10-22 13:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 11:54 [LTP] [PATCH] lib: tst_device: Scale loop device detach timeout Sebastian Chlad
2026-10-22 13:07 ` Cyril Hrubis
2026-10-22 13:09 ` Cyril Hrubis [this message]
2026-10-22 13:32 ` [LTP] " linuxtestproject.agent
2026-10-27 14:27 ` [LTP] [PATCH v2] lib: tst_device: Use exponential backoff for loop device detach Sebastian Chlad
2026-10-27 19:04 ` [LTP] " linuxtestproject.agent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atoLFrOnClQt2UuL@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=sebastianchlad@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.