Re: [Buildroot] [PATCH 4/4] package/fluent-bit: bump fluent-bit to 5.1.2

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

Thanks for your patch. However, why is this PATCH 4/4 ? I haven't not
seen your PATCH 1/4, 2/4 and 3/4. Is this a mistake or was there a
technical issue (perhaps on our side)?

On Thu, Oct 22, 2026 at 06:42:12PM +0200, Aaron Mestdagh wrote:
> From: Aaron <aaron.mestdagh@barco.com>

Could you please fix your Git setup so that your full name is first
name + last name ?

> Upgrade from 4.2.0 to 5.1.2, bringing multi-worker network ingestion
> and improved OpenTelemetry processing.
> 
> The 5.x releases also add Google Cloud Storage output, Windows Event
> Tracing input, NVIDIA GPU metrics, and new metrics processors, alongside
> FIPS, TLS, and proxy improvements.

Did you run this update through ./utils/test-pkg ?

> Signed-off-by: Aaron <aaron.mestdagh@barco.com>

Your Git setup should also make sure this uses first name + last name.

> diff --git a/package/fluent-bit/0001-ripser-initialize-temporary-entry.patch b/package/fluent-bit/0001-ripser-initialize-temporary-entry.patch
> new file mode 100644
> index 0000000000..c98bce88a9
> --- /dev/null
> +++ b/package/fluent-bit/0001-ripser-initialize-temporary-entry.patch
> @@ -0,0 +1,18 @@
> +From: Buildroot package compatibility
> +Subject: [PATCH] ripser: initialize temporary diameter entry
> +Upstream: https://github.com/Ripser/ripser
> +
> +GCC 6 does not accept the implicit default construction of
> +diameter_entry_t. The temporary is assigned before it is used, so initialize
> +it with Ripser's existing invalid-index sentinel.
> +
> +Upstream-Status: Pending (https://github.com/fluent/fluent-bit/pull/12533)
> +
> +Signed-off-by: Aaron <aaron.mestdagh@barco.com>

This patch looks very odd. Could you please generate your patch with
git format-patch? Or now that it has been merged, just take
https://github.com/fluent/fluent-bit/commit/56df8d278c927b2e7b81d28d7c08128fd7ded167.patch ?

Use an Upstream: tag pointing to the upstream commit, i.e
https://github.com/fluent/fluent-bit/commit/56df8d278c927b2e7b81d28d7c08128fd7ded167.

Could you send a v2 after addressing those comments?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot