From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CE42606A31B for ; Thu, 22 Oct 2026 23:35:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=treblig.org header.i=@treblig.org header.a=rsa-sha256 header.s=bytemarkmx header.b=OKFBh8DM Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xK2J6-0006IY-9m; Thu, 22 Oct 2026 19:34:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xK2Iw-0006HF-Ei; Thu, 22 Oct 2026 19:34:38 -0400 Received: from mx.treblig.org ([2a00:1098:5b::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xK2Iu-0006rg-Ia; Thu, 22 Oct 2026 19:34:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=Content-Type:MIME-Version:Message-ID:Subject:From:Date:From :Subject; bh=J+CdFJ+T5/iPYV5+nMs5ZJs/SnS81MtldlylrX1bu+I=; b=OKFBh8DMHVKCF+vF khMdazGtsjUU+WyZWSGlDb0YDfMjKGniRXaviZrHeFXYcze/RwL0US+9ljIIBYIh5gjF/bEap2XlV cLCfNCgj4sSMlvYsijY3Ky8HLPuNNJF/QnLfmdlpHmfxE2zXefQwjLp6lJRQHReSITymQtdwVXIDz RkuiyQkJKDq7J9Co4B/JlyWJW2X7bmfsl33NAocmMK7bwEE7tfKy9Sf4ZtS2xESvR4Y3BeJgag38b MQBgO1pJM5E3Lvg/ksND8XbSOsGAoxgiG/DYn/+d4i1qYXhBqh3yWTsrkzFcbww7Ff41JR0eg3E7J bMp4LPBOoTNR783LFg==; Received: from dg by mx.treblig.org with local (Exim 4.98.2) (envelope-from ) id 1xK2Ii-00000001zA1-484R; Thu, 22 Oct 2026 23:34:24 +0000 Date: Thu, 22 Oct 2026 23:34:24 +0000 From: "Dr. David Alan Gilbert" To: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau Cc: qemu-devel@nongnu.org, Alex =?iso-8859-1?Q?Benn=E9e?= , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Zhao Liu , Peter Maydell , Chinmay Rath , Nicholas Piggin , Glenn Miles , Harsh Prateek Bora , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Chao Liu , Max Filippov , qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, Paolo Bonzini , Laurent Vivier , Mark Cave-Ayland , Artyom Tarasenko , Helge Deller , Pierrick Bouvier , Warner Losh , Kyle Evans , Fabiano Rosas , Laurent Vivier Subject: Re: [PATCH v3 11/18] target/i386: drop HMP $pc Message-ID: References: <20261022-query-reg-v3-0-7ad902b9a7cf@redhat.com> <20261022-query-reg-v3-11-7ad902b9a7cf@redhat.com> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20261022-query-reg-v3-11-7ad902b9a7cf@redhat.com> X-Chocolate: 70 percent or better cocoa solids preferably X-Operating-System: Linux/6.12.113+deb13-amd64 (x86_64) X-Uptime: 23:23:42 up 6 days, 8:44, 2 users, load average: 0.01, 0.02, 0.00 User-Agent: Mutt/2.2.13 (2024-03-09) Received-SPF: pass client-ip=2a00:1098:5b::1; envelope-from=dg@treblig.org; helo=mx.treblig.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 * Marc-André Lureau (marcandre.lureau@redhat.com) wrote: > The to be deprecated MonitorDef provided a synthetic $pc alias on > x86 (which begin as an $eip alias). Preserving it requires x86-specific > semantics (CPUClass::get_pc() omits the historical truncation). > Use $eip or $rip instead, adding $cs.base as required. > > It was never a documented feature, HMP is not a stable API, x86-only, > and the replacement ($rip/$eip + $cs.base) is arguably more correct. > Nobody asked for a deprecation window on ML either. > > Signed-off-by: Marc-André Lureau > diff --git a/tests/qtest/test-hmp.c b/tests/qtest/test-hmp.c > index a523dbb446ce..b3f8fd58612d 100644 > --- a/tests/qtest/test-hmp.c > +++ b/tests/qtest/test-hmp.c > @@ -58,7 +58,6 @@ static const char *hmp_cmds[] = { > "object_del mem1", > "one-insn-per-tb on", > "pmemsave 0 4096 \"/dev/null\"", > - "p $pc + 8", That leaves us with no test of the 'p' command, and no test of reading a register. Given how much you're changing accessing the registers you should still have a basic test by the end. How does this test work on S390 where 'info registers' shows NIP but 'p $pc' works but 'p $nip' doesn't? I assume gdb also has some concept of a 'pc' at it's end? Dave > "qom-list /", > "qom-set /machine initrd test", > "qom-get /machine initrd", > > -- > 2.56.0.116.g6de20f6092dc > -- -----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/