All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Buildroot List <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH] package/pkg-autotools.mk: further refine libtool 2.6 patching
Date: Fri, 23 Oct 2026 09:38:33 +0200	[thread overview]
Message-ID: <atsOr7voZR_wkANg@windsurf> (raw)
In-Reply-To: <20261011074658.1888569-1-thomas.petazzoni@bootlin.com>

On Sun, Oct 11, 2026 at 09:46:58AM +0200, Thomas Petazzoni via buildroot wrote:
> 5dbba2616f287cf6d333a0849ef870b0ce49f24f ("package/pkg-autotools.mk:
> also handle libtool 2.6.x") added some patching logic for libtool
> 2.6.x, in order to fix a build issue in cryptsetup, which uses libtool
> 2.6.2.
> 
> However, the change in this commit applied the newly added libtool
> patch to all 2.6.x libtool versions.. which broke libmodbus that uses
> libtool 2.6.0, and unfortunately the ltmain.sh in libtool 2.6.0 and
> 2.6.2 is sufficiently different that the same patch doesn't apply to
> both.
> 
> So we:
> 
> 1. Rename buildroot-libtool-v2.6.patch to buildroot-libtool-v2.6.2.patch
> 
> 2. Introduce a buildroot-libtool-v2.6.0.patch
> 
> 3. Update the logic in pkg-autotools.mk to apply
>    buildroot-libtool-v2.6.0.patch to libtool 2.6.0 and 2.6.1, and
>    buildroot-libtool-v2.6.2.patch to libtool 2.6.2 and later. Note that
>    we didn't test with libtool 2.6.1 as we didn't identify a package
>    using this libtool version: we for now assume that it will be like
>    2.6.0, and will fix later if needed.
> 
> Fixes: https://autobuild.buildroot.net/results/3faf9e6889cbe33019141450a95023c730a6d03c/
> Fixes: 5dbba2616f287cf6d333a0849ef870b0ce49f24f ("package/pkg-autotools.mk: also handle libtool 2.6.x")
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

I took the freedom of applying my own patch, because just yesterday we
had 23 build failures of libmodbus because of this, and I believe the
patch was quite obvious.

Best regards,

Thomas Petazzoni
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2026-10-23  7:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-11  7:46 [Buildroot] [PATCH] package/pkg-autotools.mk: further refine libtool 2.6 patching Thomas Petazzoni via buildroot
2026-10-23  7:38 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=atsOr7voZR_wkANg@windsurf \
    --to=buildroot@buildroot.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.