From: Patrick Steinhardt <ps@pks.im>
To: Andy Koppe <andy.koppe@gmail.com>
Cc: git@vger.kernel.org, Karthik Nayak <karthik.188@gmail.com>,
Julia Evans <julia@jvns.ca>
Subject: Re: [PATCH 4/5] refs: stop calling root refs pseudorefs
Date: Fri, 23 Oct 2026 09:41:59 +0200 [thread overview]
Message-ID: <atsPx0Wn9tyMzpCl@pks.im> (raw)
In-Reply-To: <20261022212903.177261-5-andy.koppe@gmail.com>
On Thu, Oct 22, 2026 at 10:28:52PM +0100, Andy Koppe wrote:
> Some messages and comments in the code still use "pseudoref" in its old
> sense of any ref outside of "refs/", whereas the glossary now calls
> those root refs and restricts pseudorefs to FETCH_HEAD and MERGE_HEAD.
>
> Replace "pseudoref" with "root ref" in the help text for
> "git for-each-ref --include-root-refs", in comments in refs.h, and in
> comments in the bash completion script, including the one for
> __git_pseudoref_exists(), which is also used for root refs.
I feel like this sentence is somewhat pointless, as you basically
just explain the diff.
> The function
> itself is not renamed. There is no obvious term covering both root refs
> and pseudorefs, and the old name might need to be kept for third-party
> completion scripts.
This is useful though.
> Update the description of pseudorefs in refs.h to match the glossary.
And this is again info that can simply be dropped.
Patrick
next prev parent reply other threads:[~2026-10-23 7:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 21:28 [PATCH 0/5] root refs vs pseudorefs Andy Koppe
2026-10-22 21:28 ` [PATCH 1/5] doc: glossary: add root ref and clarify pseudorefs Andy Koppe
2026-10-22 22:07 ` Junio C Hamano
2026-10-23 7:41 ` Patrick Steinhardt
2026-10-22 21:28 ` [PATCH 2/5] doc: glossary: update per-worktree refs Andy Koppe
2026-10-23 7:41 ` Patrick Steinhardt
2026-10-22 21:28 ` [PATCH 3/5] doc: stop calling root refs pseudorefs Andy Koppe
2026-10-23 7:41 ` Patrick Steinhardt
2026-10-22 21:28 ` [PATCH 4/5] refs: " Andy Koppe
2026-10-23 7:41 ` Patrick Steinhardt [this message]
2026-10-22 21:28 ` [PATCH 5/5] t: " Andy Koppe
2026-10-22 22:18 ` [PATCH 0/5] root refs vs pseudorefs Junio C Hamano
2026-10-23 13:21 ` Julia Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atsPx0Wn9tyMzpCl@pks.im \
--to=ps@pks.im \
--cc=andy.koppe@gmail.com \
--cc=git@vger.kernel.org \
--cc=julia@jvns.ca \
--cc=karthik.188@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.