From: Frederic Weisbecker <frederic@kernel.org>
To: Peng Wang <peng_wang@linux.alibaba.com>
Cc: Anna-Maria Behnsen <anna-maria@linutronix.de>,
Ingo Molnar <mingo@kernel.org>, Thomas Gleixner <tglx@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
He Rongguang <herongguang@linux.alibaba.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] tick/nohz: Reevaluate the tick for kicks flushed outside hardirq
Date: Fri, 23 Oct 2026 17:07:46 +0200 [thread overview]
Message-ID: <att4QqLE4ZsOJwxN@localhost.localdomain> (raw)
In-Reply-To: <20261023145101.8217-1-peng_wang@linux.alibaba.com>
Le Fri, Oct 23, 2026 at 10:51:00PM +0800, Peng Wang a écrit :
> The nohz full kick relies on IRQ exit to reevaluate the tick. However,
> a remote kick can also be flushed from task context without an IRQ
> exit guaranteed to follow. If a tick dependency is set or an earlier
> timer is queued after the idle-exit reevaluation, the required tick
> update can be delayed until another interrupt.
>
> Reevaluate the tick directly from the callback outside hardirq context.
> Keep the existing IRQ-exit handling for hardirq callbacks. The offline
> flush remains harmless because tick_sched_timer_dying() has already
> cleared TS_FLAG_NOHZ.
>
> Fixes: 4b44a21dd640 ("irq_work, smp: Allow irq_work on call_single_queue")
> Fixes: a5183862e76f ("tick/nohz: Conditionally restart tick on idle exit")
> Suggested-by: Frederic Weisbecker <frederic@kernel.org>
> Co-developed-by: He Rongguang <herongguang@linux.alibaba.com>
> Signed-off-by: He Rongguang <herongguang@linux.alibaba.com>
> Signed-off-by: Peng Wang <peng_wang@linux.alibaba.com>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
Thanks a lot!
--
Frederic Weisbecker
SUSE Labs
next prev parent reply other threads:[~2026-10-23 15:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-17 12:59 [PATCH] tick/nohz: Requeue kicks flushed outside hardirq context Peng Wang
2026-10-22 14:36 ` Frederic Weisbecker
2026-10-22 17:54 ` [PATCH v2] tick/nohz: Reevaluate the tick for kicks flushed outside hardirq Peng Wang
2026-10-23 13:31 ` Frederic Weisbecker
2026-10-23 14:51 ` [PATCH v3] " Peng Wang
2026-10-23 15:07 ` Frederic Weisbecker [this message]
2026-10-25 21:47 ` [tip: timers/urgent] " tip-bot2 for Peng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=att4QqLE4ZsOJwxN@localhost.localdomain \
--to=frederic@kernel.org \
--cc=anna-maria@linutronix.de \
--cc=herongguang@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peng_wang@linux.alibaba.com \
--cc=peterz@infradead.org \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.