All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH] tests: shell: Fix for spurious fail in maps/typeof_maps_add_delete
Date: Fri, 23 Oct 2026 15:04:47 +0200	[thread overview]
Message-ID: <attbb5tyYBtQRjU2@orbyte.nwl.cc> (raw)
In-Reply-To: <attLaqI7J7QcsupL@strlen.de>

On Fri, Oct 23, 2026 at 01:56:26PM +0200, Florian Westphal wrote:
> Phil Sutter <phil@nwl.cc> wrote:
> > Testing on a (probably slow) aarch64 machine yielded dump failure since
> > ruleset listing had '# count 1' appended to map size statement. The 3s
> > delay supposedly wasn't long enough for the element to be reapped after
> > disabling.
> > 
> > The test itself seems to perform all desired ruleset checks though, so
> > just drop the stored dumps to avoid this problem.
> 
> Annoying, but spurious failures suck more:

Well, there might be another way involving timeout and gc-interval
tweaks, but AIUI the test didn't intend to check gc reliability or
"performance". Moreover, delayed execution of gc due to high system load
is expected, right?

Sadly, it's not the only test which becomes unstable with system load
and delays. Looking at estimate_timeout in sets/0044interval_overlap_0,
variance in system load may also reduce test stability. :(

> Acked-by: Florian Westphal <fw@strlen.de>

Thanks, Phil

  reply	other threads:[~2026-10-23 13:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-23 10:36 [nft PATCH] tests: shell: Fix for spurious fail in maps/typeof_maps_add_delete Phil Sutter
2026-10-23 11:56 ` Florian Westphal
2026-10-23 13:04   ` Phil Sutter [this message]
2026-10-23 13:26 ` Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=attbb5tyYBtQRjU2@orbyte.nwl.cc \
    --to=phil@nwl.cc \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.