From: Jarkko Sakkinen <jarkko@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
David Howells <dhowells@redhat.com>,
keyrings@vger.kernel.org,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>, Kees Cook <kees@kernel.org>,
Ilya Leoshkevich <iii@linux.ibm.com>,
Anastasia Eskova <anastasia.eskova@ibm.com>,
Peter Oberparleiter <oberpar@linux.ibm.com>,
linux-s390@vger.kernel.org
Subject: Re: [PATCH] s390/cert_store: Hold the keyring->sem while invalidating keys
Date: Sat, 24 Oct 2026 19:15:40 +0300 [thread overview]
Message-ID: <atzZrGdjJhrivcQ0@kernel.org> (raw)
In-Reply-To: <sashiko-outbox-183758@kernel.org>
On Sat, Oct 24, 2026 at 02:58:25PM +0000, sashiko-bot@kernel.org wrote:
> include/linux/cleanup.h notes that goto-based cleanup and scope-based cleanup
> helpers should not be mixed within the same function. Could key_array also be
> declared with __free(kfree) = NULL so the out label and goto can be dropped,
> or should explicit down_read() and up_read() calls be used instead?
This was actually a "design choice" as it is out of scope for the bug
fix.
Br, Jarkko
next prev parent reply other threads:[~2026-10-24 16:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-24 14:42 [PATCH] s390/cert_store: Hold the keyring->sem while invalidating keys Jarkko Sakkinen
2026-10-24 14:58 ` sashiko-bot
2026-10-24 16:15 ` Jarkko Sakkinen [this message]
2026-10-28 15:34 ` Heiko Carstens
2026-10-28 15:59 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atzZrGdjJhrivcQ0@kernel.org \
--to=jarkko@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=anastasia.eskova@ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=dhowells@redhat.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=kees@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=oberpar@linux.ibm.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.