From: Florian Westphal <fw@strlen.de>
To: alireza@asgari.net
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Phil Sutter <phil@nwl.cc>,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
kunit-dev@googlegroups.com
Subject: Re: [PATCH RFC net 2/3] netfilter: nfnetlink_queue: fix batch verdict ordering across large ID gaps
Date: Fri, 6 Nov 2026 05:45:34 +0100 [thread overview]
Message-ID: <au1bbkpwnSzzb3l4@strlen.de> (raw)
In-Reply-To: <20261106-nfqueue-review-v1-2-b6c933f44943@asgari.net>
Alireza Asgari via B4 Relay <devnull+alireza.asgari.net@kernel.org> wrote:
> From: Alireza Asgari <alireza@asgari.net>
>
> Signed 32-bit ID differences do not order packets separated by half an
> ID cycle or more. Queue length does not bound this distance: an old
> packet can remain queued while newer packets receive individual verdicts.
> For IDs [1, 0x80000002], batching through 1 incorrectly selects both.
> For [1, 2, 0x80000003], removing 2 before batching through it also selects
> both remaining packets instead of only 1.
BATCH verdicts require strict in-sequence ordering.
next prev parent reply other threads:[~2026-11-06 4:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 0:37 [PATCH RFC net 0/3] netfilter: nfnetlink_queue: handle packet ID reuse and large gaps Alireza Asgari
2026-11-06 0:37 ` Alireza Asgari via B4 Relay
2026-11-06 0:37 ` [PATCH RFC net 1/3] netfilter: nfnetlink_queue: reject duplicate pending packet IDs Alireza Asgari
2026-11-06 0:37 ` Alireza Asgari via B4 Relay
2026-11-06 0:37 ` [PATCH RFC net 2/3] netfilter: nfnetlink_queue: fix batch verdict ordering across large ID gaps Alireza Asgari
2026-11-06 0:37 ` Alireza Asgari via B4 Relay
2026-11-06 4:45 ` Florian Westphal [this message]
2026-11-06 0:37 ` [PATCH RFC net 3/3] netfilter: nfnetlink_queue: test packet ID ordering and collisions Alireza Asgari
2026-11-06 0:37 ` Alireza Asgari via B4 Relay
2026-11-06 0:41 ` [PATCH RFC net 0/3] netfilter: nfnetlink_queue: handle packet ID reuse and large gaps netdev-bot+sinfo
2026-11-06 4:54 ` Florian Westphal
2026-11-06 9:46 ` Alireza Asgari
2026-11-06 14:55 ` Florian Westphal
2026-11-06 15:42 ` Alireza Asgari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=au1bbkpwnSzzb3l4@strlen.de \
--to=fw@strlen.de \
--cc=alireza@asgari.net \
--cc=kunit-dev@googlegroups.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.