From: Florian Westphal <fw@strlen.de>
To: Phil Sutter <phil@nwl.cc>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
netfilter-devel@vger.kernel.org, xelra <xelra@protonmail.com>
Subject: Re: [nft PATCH 2/3] scanner: Fix delayed start condition pop logic
Date: Fri, 6 Nov 2026 05:57:05 +0100 [thread overview]
Message-ID: <au1eIaNvvVpgUPZJ@strlen.de> (raw)
In-Reply-To: <20261105173713.72238-3-phil@nwl.cc>
Phil Sutter <phil@nwl.cc> wrote:
> If scanner_pop_start_cond() is called and the passed start condition is
> currently active, it is supposed to pop it and all delayed states
> identified by a zero field value in state->startcond_active. The counter
> state->flex_state_pop reflects the number of delayed start conditions
> waiting to be popped.
>
> The implementation mixed up popping of the currently active state with
> delayed ones though and therefore decremented flex_state_pop for the
> currently active (i.e., not delayed) state as well. As a consequence,
> the first delayed state remained active after the function returned,
> causing problems in corner-cases.
Right, it doesn't matter for inclusive states.
Thanks for fixing this up.
next prev parent reply other threads:[~2026-11-06 4:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 17:37 [nft PATCH 0/3] Fix for exclusive start cond corner cases Phil Sutter
2026-11-05 17:37 ` [nft PATCH 1/3] parser_bison: Fix for comment following exclusive start cond Phil Sutter
2026-11-05 17:37 ` [nft PATCH 2/3] scanner: Fix delayed start condition pop logic Phil Sutter
2026-11-06 4:57 ` Florian Westphal [this message]
2026-11-05 17:37 ` [nft PATCH 3/3] scanner: Add start condition debugging Phil Sutter
2026-11-06 13:49 ` [nft PATCH 0/3] Fix for exclusive start cond corner cases Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=au1eIaNvvVpgUPZJ@strlen.de \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
--cc=xelra@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.