From: "Oscar Salvador (SUSE)" <osalvador@kernel.org>
To: Qi Zheng <qi.zheng@linux.dev>
Cc: muchun.song@linux.dev, osalvador@suse.de, david@kernel.org,
akpm@linux-foundation.org, azpijr@gmail.com,
lance.yang@linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, stable@vger.kernel.org,
Qi Zheng <zhengqi.arch@bytedance.com>
Subject: Re: [PATCH v2 3/4] mm: hugetlb: fix GFP mask propagation to CMA
Date: Fri, 6 Nov 2026 06:50:45 +0100 [thread overview]
Message-ID: <au1qtSMDpimURGuq@localhost.localdomain> (raw)
In-Reply-To: <1535887c-6be2-4415-b54e-2008e6e7a35c@linux.dev>
On Fri, Nov 06, 2026 at 10:43:53AM +0800, Qi Zheng wrote:
> I'd still prefer to keep __GFP_COMP so that
> cma_alloc_frozen_compound() itself guarantees compound allocation,
> without requiring callers to supply the flag.
Well, but aren't all callers hugetlb? And we already do supply __GFP_COMP there
for evident reasons.
And should that not be the case, and you want to catch someone who went rogue,
I would just place a WARN_ON_ONCE to catch it here, so we know who is not following
the rules.
Makes sense?
--
Oscar Salvador
SUSE Labs
next prev parent reply other threads:[~2026-11-06 5:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 4:07 [PATCH v2 0/4] mm: hugetlb: fix CMA-related issues Qi Zheng
2026-11-05 4:07 ` [PATCH v2 1/4] x86: hugetlb: disable default CMA reservations on 32-bit kernel Qi Zheng
2026-11-05 9:29 ` Oscar Salvador (SUSE)
2026-11-05 4:07 ` [PATCH v2 2/4] mm: gup: allow long-term pins of CMA-allocated HugeTLB folios Qi Zheng
2026-11-05 5:13 ` Muchun Song
2026-11-06 2:48 ` Qi Zheng
2026-11-06 2:54 ` Muchun Song
2026-11-05 9:33 ` Oscar Salvador (SUSE)
2026-11-05 11:28 ` Jose A. Perez de Azpillaga
2026-11-05 4:07 ` [PATCH v2 3/4] mm: hugetlb: fix GFP mask propagation to CMA Qi Zheng
2026-11-05 5:17 ` Muchun Song
2026-11-05 10:00 ` Oscar Salvador (SUSE)
2026-11-06 2:43 ` Qi Zheng
2026-11-06 5:50 ` Oscar Salvador (SUSE) [this message]
2026-11-06 6:12 ` Qi Zheng
2026-11-05 11:28 ` Jose A. Perez de Azpillaga
2026-11-05 4:07 ` [PATCH v2 4/4] mm: hugetlb: fix cpuset violations in gigantic surplus allocations Qi Zheng
2026-11-05 5:15 ` sashiko-bot
2026-11-06 7:43 ` Qi Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=au1qtSMDpimURGuq@localhost.localdomain \
--to=osalvador@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=azpijr@gmail.com \
--cc=david@kernel.org \
--cc=lance.yang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
--cc=qi.zheng@linux.dev \
--cc=stable@vger.kernel.org \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.