From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netfilter-devel@vger.kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, pabeni@redhat.com, edumazet@kernel.org,
horms@kernel.org, fw@strlen.de, ja@ssi.bg
Subject: Re: [PATCH net,v4 00/12] Netfilter/IPVS fixes
Date: Fri, 6 Nov 2026 12:42:47 +0100 [thread overview]
Message-ID: <au29N1V8ogEUKDyd@chamomile> (raw)
In-Reply-To: <au26c2NFsX6gCCPo@chamomile>
On Fri, Nov 06, 2026 at 12:30:59PM +0100, Pablo Neira Ayuso wrote:
> On Thu, Nov 05, 2026 at 03:48:08PM -0800, Jakub Kicinski wrote:
> > On Thu, 5 Nov 2026 13:45:24 +0100 Pablo Neira Ayuso wrote:
> > > v4: - Drop "ipvs: do not create conns from packets with port 0".
> > >
> > > This PR was already reviewed in its v2 by netdev-ai-bots.
> > > I have dropped all the patches that LLM flagged as needing
> > > more work even since.
> > >
> > > But I really think v3 was good enough and a follow up for
> > > "ipvs: do not create conns from packets with port 0"
> > > was just fine to proceed.
> > >
> > > Maybe patchbot will ban this pull request again, v3 was
> > > blocklisted for not fulfulling the 24 hours rule, that is
> > > why it was not reviewed.
> > >
> > > But, as said, this was all reviewed in PR v2 already, this
> > > is just keeping back 3 patches included in PR v1 needing
> > > more work.
> >
> > netdev CI keeps hitting a kmemleak since this morning, lines up with
> > this series, tho TBH I have done 0 investigating...
To clarify further: I think it is just a coincidence, I don't see
anything in this PR related to this.
There is a known bug related to this in the pernetns exit path, I post
a patch already but is flawed, I'm looking at improving the situation
with a bug fix :-)
> > $ cat /sys/kernel/debug/kmemleak
> > unreferenced object (percpu) 0xc0ffff86522458 (size 12):
> > comm "modprobe", pid 17854, jiffies 4295218150
> > hex dump (first 12 bytes on cpu 0):
> > 00 00 00 00 00 00 00 00 00 00 00 00 ............
> > backtrace (crc 0):
> > pcpu_alloc_noprof+0x76b/0xd70
> > nf_flow_table_pernet_init+0x46/0x90 [nf_flow_table]
>
> This is not handled by this PR.
>
> I will submit a patch for this asap.
>
> > ops_init+0x187/0x570
> > register_pernet_operations+0x395/0x8e0
> > register_pernet_subsys+0x28/0x40
> > nft_masq_dump+0x66/0x190 [nft_masq]
> > do_one_initcall+0x124/0x4f0
> > do_init_module+0x2ad/0x8a0
> > load_module+0x154b/0x1d60
> > init_module_from_file+0x11f/0x1a0
> > idempotent_init_module+0x37b/0x7c0
> > __x64_sys_finit_module+0xdf/0x190
> > do_syscall_64+0x10e/0x570
> > entry_SYSCALL_64_after_hwframe+0x4b/0x53
> >
>
prev parent reply other threads:[~2026-11-06 11:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 12:45 [PATCH net,v4 00/12] Netfilter/IPVS fixes Pablo Neira Ayuso
2026-11-05 12:45 ` [PATCH net 01/12] netfilter: nft_reject: prevent unbounded recursion in output hooks Pablo Neira Ayuso
2026-11-05 12:50 ` netdev-bot+sinfo
2026-11-05 12:54 ` Pablo Neira Ayuso
2026-11-06 20:40 ` patchwork-bot+netdevbpf
2026-11-05 12:45 ` [PATCH net 02/12] ipvs: Defer application parent freeing until after RCU readers Pablo Neira Ayuso
2026-11-05 12:45 ` [PATCH net 03/12] ipvs: fix protocol data lifetime during namespace teardown Pablo Neira Ayuso
2026-11-05 12:45 ` [PATCH net 04/12] netfilter: nf_dup: preserve guard across NFQUEUE reinjection Pablo Neira Ayuso
2026-11-05 12:45 ` [PATCH net 05/12] netfilter: flowtable: extend ct timeout of offloaded GRE flows Pablo Neira Ayuso
2026-11-05 12:45 ` [PATCH net 06/12] netfilter: nft_set_rbtree: check catchall_sync return before queue_done Pablo Neira Ayuso
2026-11-05 12:45 ` [PATCH net 07/12] netfilter: bridge: use DEBUG_NET_WARN_ON_ONCE in nf_ct_bridge_refrag() Pablo Neira Ayuso
2026-11-05 12:45 ` [PATCH net 08/12] netfilter: x_tables: check target name before accessing verdict Pablo Neira Ayuso
2026-11-05 12:45 ` [PATCH net 09/12] netfilter: nf_conntrack_sip: fix OOB read in ct_sip_parse_transport() Pablo Neira Ayuso
2026-11-05 12:45 ` [PATCH net 10/12] netfilter: nf_tables: fix memleak when rule deletion fails with hardware offload Pablo Neira Ayuso
2026-11-05 12:45 ` [PATCH net 11/12] netfilter: xt_recent: do not call remove_proc_entry() under recent_lock Pablo Neira Ayuso
2026-11-05 12:45 ` [PATCH net 12/12] netfilter: nat: zero newrange before filling it in Pablo Neira Ayuso
2026-11-05 23:48 ` [PATCH net,v4 00/12] Netfilter/IPVS fixes Jakub Kicinski
2026-11-06 11:30 ` Pablo Neira Ayuso
2026-11-06 11:42 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=au29N1V8ogEUKDyd@chamomile \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=ja@ssi.bg \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.