From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
David Rhodes <david.rhodes@cirrus.com>,
Lee Jones <lee@kernel.org>,
patches@opensource.cirrus.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, mfd@lists.linux.dev
Subject: Re: [PATCH 3/4] ASoC: arizona: drop unused HPDET accessory ID support
Date: Fri, 6 Nov 2026 09:36:47 +0000 [thread overview]
Message-ID: <au2fr69ZCkgrEd+t@opensource.cirrus.com> (raw)
In-Reply-To: <20261105-arizona-asoc-v1-3-25ec7338446e@gmail.com>
On Thu, Nov 05, 2026 at 09:39:34PM -0800, Dmitry Torokhov wrote:
> Nothing in the kernel sets hpdet_acc_id or hpdet_acc_id_line in
> struct arizona_pdata, and neither has any Device Tree or ACPI bindings.
>
> Remove both platform data fields and all exclusively connected HPDET
> accessory identification logic, work items, GPIO lookup, and state from
> the Arizona jack detection driver.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
A little unsure how to proceed here. I certainly wouldn't object
to dropping the added complexity here, but I think this was used
on a couple out of tree systems. I am leaning towards we could
probably let it go?
Thanks,
Charles
next prev parent reply other threads:[~2026-11-06 9:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 5:39 [PATCH 0/4] ASoC: arizona: switch to generic device properties and clean up Dmitry Torokhov
2026-11-06 5:39 ` [PATCH 1/4] ASoC: arizona: convert audio pdata parsing to generic device properties Dmitry Torokhov
2026-11-06 5:39 ` [PATCH 2/4] ASoC: arizona: always parse device properties regardless of platform data Dmitry Torokhov
2026-11-08 12:54 ` Mark Brown
2026-11-06 5:39 ` [PATCH 3/4] ASoC: arizona: drop unused HPDET accessory ID support Dmitry Torokhov
2026-11-06 9:36 ` Charles Keepax [this message]
2026-11-06 5:39 ` [PATCH 4/4] ASoC: arizona: clean up coding style and formatting Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=au2fr69ZCkgrEd+t@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=david.rhodes@cirrus.com \
--cc=dmitry.torokhov@gmail.com \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mfd@lists.linux.dev \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.