From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C431606A326 for ; Fri, 6 Nov 2026 15:45:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=WLPYf/A/ Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xPM7x-0000pv-A4; Fri, 06 Nov 2026 10:45:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xPM7u-0000pk-L2 for qemu-devel@nongnu.org; Fri, 06 Nov 2026 10:45:14 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xPM7s-0000Kf-GC for qemu-devel@nongnu.org; Fri, 06 Nov 2026 10:45:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1793979911; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bN6szWcjrdT2r3koHBr3kDBQGnFdRz3atijPZSCM5fA=; b=WLPYf/A/7+FQZdu0W0TpklI1VgYqYu68Z9qhdDzE+NUGf6Wo1jUwauCNWz3WOFsQqfnFSV Wn3dB3mrF2N0aDHn3SsZ6JzQ8KzkDGf+NNCQcqVGockJOZoQx6FYR4eZZ7KfaGnxJIRRCu Ptbdmzvrc5V4OhPOo6knMbAXpF2PlBc= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-265-w5i518WdPWWKluRJR4ElWA-1; Fri, 06 Nov 2026 10:45:07 -0500 X-MC-Unique: w5i518WdPWWKluRJR4ElWA-1 X-Mimecast-MFC-AGG-ID: w5i518WdPWWKluRJR4ElWA_1793979906 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BFA8D1955EAA; Fri, 6 Nov 2026 15:45:05 +0000 (UTC) Received: from redhat.com (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0FC881956089; Fri, 6 Nov 2026 15:45:03 +0000 (UTC) Date: Fri, 6 Nov 2026 15:45:01 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Yonggang Luo Cc: qemu-devel@nongnu.org, Pierrick Bouvier , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Paolo Bonzini , Philippe Mathieu-Daude Subject: Re: [PATCH 2/5] target-info: add target_mask_selected() Message-ID: References: <20261105190346.1539-1-luoyonggang@gmail.com> <20261105190346.1539-3-luoyonggang@gmail.com> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20261105190346.1539-3-luoyonggang@gmail.com> User-Agent: Mutt/2.4.3 (2026-10-09) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Fri, Nov 06, 2026 at 03:03:43AM +0800, Yonggang Luo wrote: > Return the QEMU_ARCH_* mask of the selected target. System mode > returns QEMU_ARCH_ALL until a target is selected. User mode returns > that target's bit. Tools return 0. I was wondering if it was better to have system mode return 0 or QEMU_ARCH_ALL, when no target is selected. I guess QEMU_ARCH_ALL (or a mask of all arches that are built-in to the bniary) is a better approach, as it expresses that the system's current state is capable of targetting any of the include arches, while '0' conceptually represents the "no arch specific features" scenario for tools. > > Signed-off-by: Yonggang Luo > --- > include/qemu/target-info-init.h | 15 ++++++++++----- > include/qemu/target-info.h | 9 +++++++++ > stubs/meson.build | 1 + > stubs/target-mask-selected.c | 13 +++++++++++++ > target-info-def.c | 3 +++ > target-info-qom.c | 10 ++++++++++ > 6 files changed, 46 insertions(+), 5 deletions(-) > create mode 100644 stubs/target-mask-selected.c Reviewed-by: Daniel P. Berrangé this patch looks applicable independently of this series. With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|