From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Joseph Telaak <joseph@telaak.dev>
Cc: Linus Walleij <linusw@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Chuanhong Guo <gch981213@gmail.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] pinctrl: Add Siflower SF19A2890 pin controller driver
Date: Fri, 6 Nov 2026 18:01:12 +0100 [thread overview]
Message-ID: <au4HsW2aMYKyMspF@monoceros> (raw)
In-Reply-To: <20261104-sf19a2890-pinctrl-v1-2-4bb83afdbacf@telaak.dev>
[-- Attachment #1: Type: text/plain, Size: 364 bytes --]
Hello,
On Wed, Nov 04, 2026 at 02:21:18AM -0500, Joseph Telaak wrote:
> +#include <linux/mod_devicetable.h>
> [...]
> +#include <linux/platform_device.h>
Please don't use <linux/mod_devicetable.h>. <linux/platform_device.h> is
good enough to provide of_device_id already. If you insist on full iwyu,
please use <linux/device-id/of.h> instead.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-11-06 17:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 7:21 [PATCH 0/2] pinctrl: Add the Siflower SF19A2890 pin controller Joseph Telaak
2026-11-04 7:21 ` Joseph Telaak via B4 Relay
2026-11-04 7:21 ` [PATCH 1/2] dt-bindings: pinctrl: Add " Joseph Telaak
2026-11-04 7:21 ` Joseph Telaak via B4 Relay
2026-11-04 23:49 ` Conor Dooley
2026-11-05 0:45 ` Joseph Telaak
2026-11-04 7:21 ` [PATCH 2/2] pinctrl: Add Siflower SF19A2890 pin controller driver Joseph Telaak
2026-11-04 7:21 ` Joseph Telaak via B4 Relay
2026-11-04 7:34 ` sashiko-bot
2026-11-04 23:54 ` Conor Dooley
2026-11-05 0:54 ` Joseph Telaak
2026-11-05 1:35 ` Conor Dooley
2026-11-05 4:45 ` Joseph Telaak
2026-11-05 12:13 ` kernel test robot
2026-11-06 17:01 ` Uwe Kleine-König [this message]
2026-11-08 22:07 ` Joseph Telaak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=au4HsW2aMYKyMspF@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gch981213@gmail.com \
--cc=joseph@telaak.dev \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.