From: Florian Westphal <fw@strlen.de>
To: Tamaki Yanagawa <ty@000ty.net>
Cc: netfilter-devel@vger.kernel.org, pablo@netfilter.org,
phil@nwl.cc, coreteam@netfilter.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: nfnetlink_queue: unclone skb before writing NFQA_L2HDR
Date: Sat, 7 Nov 2026 17:17:00 +0100 [thread overview]
Message-ID: <au9O_KyLej8ckT5V@strlen.de> (raw)
In-Reply-To: <20261107160517.726-1-ty@000ty.net>
Tamaki Yanagawa <ty@000ty.net> wrote:
> nfqa_parse_bridge() copies the NFQA_L2HDR attribute over the mac header
> of the queued skb in place. Bridge flooding queues clones that share
> their data with the copies sent to the other ports, so the rewritten
> header also shows up on frames that never went through the queue, and
> is changed while those may already be in transmission. Unclone the skb
> before the copy, as nfqnl_mangle() does for NFQA_PAYLOAD via
> skb_ensure_writable().
Can you explain in changelog why full unclone is needed rather than
skb_ensure_writable()?
next prev parent reply other threads:[~2026-11-07 16:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 16:05 [PATCH nf] netfilter: nfnetlink_queue: unclone skb before writing NFQA_L2HDR Tamaki Yanagawa
2026-11-07 16:17 ` Florian Westphal [this message]
2026-11-07 16:32 ` Tamaki Yanagawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=au9O_KyLej8ckT5V@strlen.de \
--to=fw@strlen.de \
--cc=coreteam@netfilter.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
--cc=ty@000ty.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.