All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mikko Rapeli <mikko.rapeli@linaro.org>
To: JPEWhacker@gmail.com
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][PATCH v5 5/6] Add SPDX deploy tasks to various recipes
Date: Tue, 27 Oct 2026 09:24:15 +0200	[thread overview]
Message-ID: <auBRnwhMKmTkFpQB@nuoska> (raw)
In-Reply-To: <20261026214627.2388650-6-JPEWhacker@gmail.com>

On Mon, Oct 26, 2026 at 03:45:25PM -0600, Joshua Watt via lists.openembedded.org wrote:
> Adds SPDX deploy tasks to many recipes to record their output when
> consumed in an SBoM

I think this should be the default in deploy.bbclass.

The class is used to deploy files to "build output". A lot of BSP etc
recipes use the class for this purpose and they are currently missing in SPDX
output unless some output packages go to image rootfs.

I think capturing too much data in SPDX is less of a problem than not capturing
enough. Thus deploy.bbclass should support SPDX output by default, when SPDX
is enabled.

If there are other very good reasons for not enabling this by default, then
I think the commit message should say that.

Cheers,

-Mikko

> Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
> ---
>  meta/classes-recipe/barebox.bbclass           | 1 +
>  meta/classes-recipe/devicetree.bbclass        | 1 +
>  meta/classes-recipe/kernel-fit-image.bbclass  | 1 +
>  meta/classes-recipe/kernel.bbclass            | 1 +
>  meta/recipes-bsp/grub/grub-efi_2.14.bb        | 1 +
>  meta/recipes-bsp/opensbi/opensbi_1.9.bb       | 1 +
>  meta/recipes-bsp/u-boot/u-boot.inc            | 1 +
>  meta/recipes-core/systemd/systemd-boot_262.bb | 2 +-
>  8 files changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/classes-recipe/barebox.bbclass b/meta/classes-recipe/barebox.bbclass
> index 3980849b53..252e97fa65 100644
> --- a/meta/classes-recipe/barebox.bbclass
> +++ b/meta/classes-recipe/barebox.bbclass
> @@ -165,5 +165,6 @@ barebox_do_deploy () {
>          fi
>  }
>  addtask deploy after do_compile
> +SPDX_DEPLOY_TASKS += "do_deploy"
>  
>  EXPORT_FUNCTIONS do_configure do_compile do_install do_deploy
> diff --git a/meta/classes-recipe/devicetree.bbclass b/meta/classes-recipe/devicetree.bbclass
> index 4fe389bed8..affbf115c2 100644
> --- a/meta/classes-recipe/devicetree.bbclass
> +++ b/meta/classes-recipe/devicetree.bbclass
> @@ -166,6 +166,7 @@ devicetree_do_deploy() {
>      done
>  }
>  addtask deploy before do_build after do_install
> +SPDX_DEPLOY_TASKS += "do_deploy"
>  
>  EXPORT_FUNCTIONS do_compile do_install do_deploy
>  
> diff --git a/meta/classes-recipe/kernel-fit-image.bbclass b/meta/classes-recipe/kernel-fit-image.bbclass
> index 7b2bcd4673..d0f7274e70 100644
> --- a/meta/classes-recipe/kernel-fit-image.bbclass
> +++ b/meta/classes-recipe/kernel-fit-image.bbclass
> @@ -260,3 +260,4 @@ do_deploy() {
>      fi
>  }
>  addtask deploy after do_compile before do_build
> +SPDX_DEPLOY_TASKS += "do_deploy"
> diff --git a/meta/classes-recipe/kernel.bbclass b/meta/classes-recipe/kernel.bbclass
> index 0a6d754108..14c71dec54 100644
> --- a/meta/classes-recipe/kernel.bbclass
> +++ b/meta/classes-recipe/kernel.bbclass
> @@ -840,6 +840,7 @@ kernel_do_deploy() {
>  do_deploy[prefuncs] += "read_subpackage_metadata"
>  
>  addtask deploy after do_install do_populate_sysroot do_packagedata
> +SPDX_DEPLOY_TASKS += "do_deploy"
>  
>  EXPORT_FUNCTIONS do_deploy
>  
> diff --git a/meta/recipes-bsp/grub/grub-efi_2.14.bb b/meta/recipes-bsp/grub/grub-efi_2.14.bb
> index d19b33b504..8d8671614a 100644
> --- a/meta/recipes-bsp/grub/grub-efi_2.14.bb
> +++ b/meta/recipes-bsp/grub/grub-efi_2.14.bb
> @@ -99,6 +99,7 @@ do_deploy() {
>  }
>  
>  addtask deploy after do_install before do_build
> +SPDX_DEPLOY_TASKS += "do_deploy"
>  
>  FILES:${PN} = "${libdir}/grub/${GRUB_TARGET}-efi \
>                 ${datadir}/grub \
> diff --git a/meta/recipes-bsp/opensbi/opensbi_1.9.bb b/meta/recipes-bsp/opensbi/opensbi_1.9.bb
> index 96167f7c73..bb35f906b2 100644
> --- a/meta/recipes-bsp/opensbi/opensbi_1.9.bb
> +++ b/meta/recipes-bsp/opensbi/opensbi_1.9.bb
> @@ -49,6 +49,7 @@ do_deploy () {
>  }
>  
>  addtask deploy before do_build after do_install
> +SPDX_DEPLOY_TASKS += "do_deploy"
>  
>  FILES:${PN} += "/share/opensbi/*/${RISCV_SBI_PLAT}/firmware/fw_jump.*"
>  FILES:${PN} += "/share/opensbi/*/${RISCV_SBI_PLAT}/firmware/fw_payload.*"
> diff --git a/meta/recipes-bsp/u-boot/u-boot.inc b/meta/recipes-bsp/u-boot/u-boot.inc
> index b9f61a185c..1c9911ff6e 100644
> --- a/meta/recipes-bsp/u-boot/u-boot.inc
> +++ b/meta/recipes-bsp/u-boot/u-boot.inc
> @@ -474,3 +474,4 @@ uboot_deploy_spl () {
>  }
>  
>  addtask deploy before do_build after do_compile
> +SPDX_DEPLOY_TASKS += "do_deploy"
> diff --git a/meta/recipes-core/systemd/systemd-boot_262.bb b/meta/recipes-core/systemd/systemd-boot_262.bb
> index bab2e7ae27..c9bc3e2a91 100644
> --- a/meta/recipes-core/systemd/systemd-boot_262.bb
> +++ b/meta/recipes-core/systemd/systemd-boot_262.bb
> @@ -71,4 +71,4 @@ do_deploy () {
>  }
>  
>  addtask deploy before do_build after do_compile
> -
> +SPDX_DEPLOY_TASKS += "do_deploy"
> -- 
> 2.56.0
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#248698): https://lists.openembedded.org/g/openembedded-core/message/248698
> Mute This Topic: https://lists.openembedded.org/mt/121950655/7159507
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [mikko.rapeli@linaro.org]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


  parent reply	other threads:[~2026-10-27  7:24 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-09 22:15 [OE-core][PATCH 0/5] Implement SPDX for deploy tasks Joshua Watt
2026-06-09 22:15 ` [OE-core][PATCH 1/5] classes/baremetal-image: Remove "do_" prefix from image manifest Joshua Watt
2026-06-09 22:15 ` [OE-core][PATCH 2/5] spdx: Reformat Joshua Watt
2026-06-09 22:15 ` [OE-core][PATCH 3/5] spdx: Add ability for deploy tasks to create SPDX Joshua Watt
2026-06-09 22:15 ` [OE-core][PATCH 4/5] Add SPDX deploy tasks Joshua Watt
2026-06-09 22:31   ` Patchtest results for " patchtest
2026-06-10  6:17   ` Mikko Rapeli
2026-06-10  7:46   ` Richard Purdie
2026-06-09 22:15 ` [OE-core][PATCH 5/5] spdx: Replace do_create_image_spdx with deploy task Joshua Watt
2026-06-10 13:17 ` [OE-core][PATCH 0/5] Implement SPDX for deploy tasks Mathieu Dubois-Briand
2026-06-11 18:46   ` Joshua Watt
2026-06-18 15:38 ` [OE-core][PATCH v2 " Joshua Watt
2026-06-18 15:38   ` [OE-core][PATCH v2 1/5] spdx: Add ability for deploy tasks to create SPDX Joshua Watt
2026-06-18 15:38   ` [OE-core][PATCH v2 2/5] classes-global/sstate: Keep SPDX generating setscene dependencies Joshua Watt
2026-06-18 15:38   ` [OE-core][PATCH v2 3/5] Add SPDX deploy tasks to various recipes Joshua Watt
2026-06-18 17:07     ` Patchtest results for " patchtest
2026-06-18 15:38   ` [OE-core][PATCH v2 4/5] spdx: Replace do_create_image_spdx with deploy task Joshua Watt
2026-06-18 15:38   ` [OE-core][PATCH v2 5/5] grub-efi: Change to MACHINE_ARCH Joshua Watt
2026-06-21  5:45   ` [OE-core][PATCH v2 0/5] Implement SPDX for deploy tasks Mathieu Dubois-Briand
2026-06-22 21:14     ` Joshua Watt
2026-06-23  9:28       ` Mathieu Dubois-Briand
2026-06-24 14:15   ` [OE-core][PATCH v3 0/8] " Joshua Watt
2026-06-24 14:15     ` [OE-core][PATCH v3 1/8] spdx: Skip dependencies that are not in the taskhash Joshua Watt
2026-06-24 14:15     ` [OE-core][PATCH v3 2/8] spdx: Add ability for deploy tasks to create SPDX Joshua Watt
2026-06-24 14:15     ` [OE-core][PATCH v3 3/8] oeqa: Add SPDX deploy SBoM test Joshua Watt
2026-06-24 14:15     ` [OE-core][PATCH v3 4/8] classes-global/sstate: Keep SPDX generating setscene dependencies Joshua Watt
2026-06-24 14:15     ` [OE-core][PATCH v3 5/8] Add SPDX deploy tasks to various recipes Joshua Watt
2026-06-24 14:31       ` Patchtest results for " patchtest
2026-06-24 14:31       ` Mikko Rapeli
2026-06-24 16:05         ` Joshua Watt
2026-06-24 16:24           ` Mikko Rapeli
2026-06-24 16:30             ` Joshua Watt
2026-06-24 14:15     ` [OE-core][PATCH v3 6/8] spdx: Replace do_create_image_spdx with deploy task Joshua Watt
2026-06-24 14:15     ` [OE-core][PATCH v3 7/8] grub-efi: Change to MACHINE_ARCH Joshua Watt
2026-06-24 14:15     ` [OE-core][PATCH v3 8/8] systemd-boot: " Joshua Watt
2026-06-25  6:21     ` [OE-core][PATCH v3 0/8] Implement SPDX for deploy tasks Mathieu Dubois-Briand
2026-06-30 21:01     ` [OE-core][PATCH v4 00/10] " Joshua Watt
2026-06-30 21:01       ` [OE-core][PATCH v4 01/10] spdx: Skip dependencies that are not in the taskhash Joshua Watt
2026-06-30 21:01       ` [OE-core][PATCH v4 02/10] spdx: Add ability for deploy tasks to create SPDX Joshua Watt
2026-06-30 21:01       ` [OE-core][PATCH v4 03/10] oeqa: Add SPDX deploy SBoM test Joshua Watt
2026-06-30 21:01       ` [OE-core][PATCH v4 04/10] classes-global/sstate: Keep SPDX generating setscene dependencies Joshua Watt
2026-06-30 21:01       ` [OE-core][PATCH v4 05/10] Add SPDX deploy tasks to various recipes Joshua Watt
2026-06-30 21:01       ` [OE-core][PATCH v4 06/10] spdx: Replace do_create_image_spdx with deploy task Joshua Watt
2026-06-30 21:01       ` [OE-core][PATCH v4 07/10] grub-efi: Change to MACHINE_ARCH Joshua Watt
2026-06-30 21:01       ` [OE-core][PATCH v4 08/10] systemd-boot: " Joshua Watt
2026-06-30 21:01       ` [OE-core][PATCH v4 09/10] multilib: Add systemd-boot to NON_MULTILIB_RECIPES Joshua Watt
2026-06-30 21:01       ` [OE-core][PATCH v4 10/10] wic-tools: Change to MACHINE_ARCH Joshua Watt
2026-07-02  7:51       ` [OE-core][PATCH v4 00/10] Implement SPDX for deploy tasks Mathieu Dubois-Briand
2026-07-05  8:29       ` Richard Purdie
     [not found]       ` <18BF5783F1D47BA6.1336494@lists.openembedded.org>
2026-07-06 14:28         ` Richard Purdie
2026-10-26 21:45       ` [OE-core][PATCH v5 0/6] " Joshua Watt
2026-10-26 21:45         ` [OE-core][PATCH v5 1/6] spdx: Skip dependencies that are not in the taskhash Joshua Watt
2026-10-26 21:45         ` [OE-core][PATCH v5 2/6] spdx: Add ability for deploy tasks to create SPDX Joshua Watt
2026-10-26 21:45         ` [OE-core][PATCH v5 3/6] oeqa: Add SPDX deploy SBoM test Joshua Watt
2026-10-26 21:45         ` [OE-core][PATCH v5 4/6] classes-global/sstate: Keep SPDX generating setscene dependencies Joshua Watt
2026-10-26 21:45         ` [OE-core][PATCH v5 5/6] Add SPDX deploy tasks to various recipes Joshua Watt
2026-10-26 22:03           ` Patchtest results for " patchtest
2026-10-27  7:24           ` Mikko Rapeli [this message]
2026-10-27 12:03             ` Jose Quaresma
2026-10-27 14:20               ` Joshua Watt
2026-10-26 21:45         ` [OE-core][PATCH v5 6/6] spdx: Replace do_create_image_spdx with deploy task Joshua Watt
2026-10-27 14:39         ` [OE-core][PATCH v5 0/6] Implement SPDX for deploy tasks Mathieu Dubois-Briand
2026-10-27 22:47         ` [OE-core][PATCH v6 0/7] " Joshua Watt
2026-10-27 22:47           ` [OE-core][PATCH v6 1/7] spdx: Skip dependencies that are not in the taskhash Joshua Watt
2026-10-27 22:47           ` [OE-core][PATCH v6 2/7] spdx: Add ability for deploy tasks to create SPDX Joshua Watt
2026-10-27 22:47           ` [OE-core][PATCH v6 3/7] oeqa: Add SPDX deploy SBoM test Joshua Watt
2026-10-27 22:47           ` [OE-core][PATCH v6 4/7] classes-global/sstate: Keep SPDX generating setscene dependencies Joshua Watt
2026-10-27 22:47           ` [OE-core][PATCH v6 5/7] classes-recipe/deploy: Add do_deploy to SPDX_DEPLOY_TASKS Joshua Watt
2026-10-27 22:47           ` [OE-core][PATCH v6 6/7] spdx: Replace do_create_image_spdx with deploy task Joshua Watt
2026-10-27 22:47           ` [OE-core][PATCH v6 7/7] layer.conf: Fix initramfs-framework not knowing which udev it has Joshua Watt
2026-10-28 17:06           ` [OE-core][PATCH v6 0/7] Implement SPDX for deploy tasks Mathieu Dubois-Briand
2026-10-28 22:04           ` [OE-core][PATCH v7 0/8] " Joshua Watt
2026-10-28 22:04             ` [OE-core][PATCH v7 1/8] spdx: Skip dependencies that are not in the taskhash Joshua Watt
2026-10-28 22:04             ` [OE-core][PATCH v7 2/8] spdx: Add ability for deploy tasks to create SPDX Joshua Watt
2026-10-28 22:04             ` [OE-core][PATCH v7 3/8] oeqa: Add SPDX deploy SBoM test Joshua Watt
2026-10-28 22:04             ` [OE-core][PATCH v7 4/8] classes-global/sstate: Keep SPDX generating setscene dependencies Joshua Watt
2026-10-28 22:04             ` [OE-core][PATCH v7 5/8] classes-recipe/deploy: Add do_deploy to SPDX_DEPLOY_TASKS Joshua Watt
2026-10-28 22:04             ` [OE-core][PATCH v7 6/8] spdx: Replace do_create_image_spdx with deploy task Joshua Watt
2026-10-28 22:04             ` [OE-core][PATCH v7 7/8] layer.conf: Fix initramfs-framework not knowing which udev it has Joshua Watt
2026-10-29 19:20               ` Mathieu Dubois-Briand
2026-10-28 22:04             ` [OE-core][PATCH v7 8/8] ovmf: Allow empty SPDX deploy artifacts Joshua Watt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auBRnwhMKmTkFpQB@nuoska \
    --to=mikko.rapeli@linaro.org \
    --cc=JPEWhacker@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.