From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D4B4606A32C for ; Tue, 27 Oct 2026 11:08:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=FnADzL63 Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xLf2Z-0001tC-V1; Tue, 27 Oct 2026 07:08:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xLf2X-0001sS-Us for qemu-devel@nongnu.org; Tue, 27 Oct 2026 07:08:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xLf2U-0002TV-Hg for qemu-devel@nongnu.org; Tue, 27 Oct 2026 07:08:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1793099301; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oKqcvBOA6U++xZnxW5OQd7PQHkpxJLgbyxtG/9Q0Hog=; b=FnADzL63hDnNo/QmmZ08i82qaFOFiNQj3nduOkAL2wWtTeTmkovxIpsL7mttqUfLvvr73o s4sNzZgQ/rqiFOqWEawxzHPeZVgumd1xKVlYGZSSbku5ayOJbbP7MxiYAp3KRgtBcLNwaY 0BH5AnUNqGBC0BBqgw1BADV37VozUp0= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-562-a3JqmgunNpiYNKcsPp4Cpw-1; Tue, 27 Oct 2026 07:08:16 -0400 X-MC-Unique: a3JqmgunNpiYNKcsPp4Cpw-1 X-Mimecast-MFC-AGG-ID: a3JqmgunNpiYNKcsPp4Cpw_1793099294 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A39CB1800D88; Tue, 27 Oct 2026 11:08:14 +0000 (UTC) Received: from redhat.com (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6F3EF300019F; Tue, 27 Oct 2026 11:08:12 +0000 (UTC) Date: Tue, 27 Oct 2026 11:08:09 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Roman Bogorodskiy Cc: qemu-devel@nongnu.org, Markus Armbruster , Paolo Bonzini , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Pierrick Bouvier , Michael Roth , Kostiantyn Kostiuk , Eric Blake Subject: Re: [PATCH v3] qga: implement 'guest-network-get-route' for FreeBSD Message-ID: References: <20261026190352.14293-1-bogorodskiy@gmail.com> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20261026190352.14293-1-bogorodskiy@gmail.com> User-Agent: Mutt/2.4.2 (2026-08-30) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, GB_FAKE_RF=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Mon, Oct 26, 2026 at 08:03:52PM +0100, Roman Bogorodskiy wrote: > Implement 'guest-network-get-route' for FreeBSD. This > implementation uses the sysctl(3) interface to get > the routing table. > > Limitations: > > - This implementation does not populate irtt, refcnt, use, > window, source, and srcprefixlen fields. > - The implementation uses the default FIB (routing table) 0. > Selecting QGA's active FIB is left for the follow-up patch. > > While here, spell Windows correctly in @GuestNetworkRoute documentation > in qapi-schema.json. > > Signed-off-by: Roman Bogorodskiy > Acked-by: Markus Armbruster > --- > Changes since v1: > > - qga/qapi-schema.json spelling: windows -> Windows, freebsd -> FreeBSD > in the "@GuestNetworkRoute" documentation. > - meson.build: check that the 'struct rt_metrics' has 'rmx_metric' > member which is available only on FreeBSD 16. > > Changes since v2: > > - If interface name cannot be obtained, default it to "if" > instead of "?", similarly to the Windows implementation. > - Use getnameinfo() for both AF_INET and AF_INET6 formatting. > > meson.build | 6 ++ > qga/commands-bsd.c | 173 +++++++++++++++++++++++++++++++++++++++++++ > qga/qapi-schema.json | 31 ++++---- > 3 files changed, 195 insertions(+), 15 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|