All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Yegor Yefremov <yegorslists@googlemail.com>
Cc: buildroot@buildroot.org, Danomi Manchego <danomimanchego123@gmail.com>
Subject: Re: [Buildroot] [PATCH] package/libwebsockets: fix OpenSSL detection without libatomic
Date: Tue, 27 Oct 2026 17:09:03 +0100	[thread overview]
Message-ID: <auDMmNNMbgZTC16s@windsurf> (raw)
In-Reply-To: <20261027081659.3905442-1-yegorslists@googlemail.com>

On Tue, Oct 27, 2026 at 09:16:59AM +0100, Yegor Yefremov wrote:
> Since version 4.5.3, libwebsockets adds -latomic to the libraries used
> by its OpenSSL API probes whenever 64-bit atomics don't work out of the
> box, without checking that libatomic is available. Buildroot toolchains
> without thread support don't provide libatomic, so on a CPU without
> native 64-bit atomics (e.g. ARMv5) all probes fail to link:
> 
>   ld: cannot find -latomic: No such file or directory
> 
> libwebsockets then assumes a pre-1.1 OpenSSL and fails to build:
> 
> -- Performing Test HAVE_WORKING_ATOMIC_64 - Failed
> [...]
> -- Looking for HMAC_CTX_new - not found
> [...]
> include/libwebsockets/lws-genhash.h:93:18: error: field 'ctx' has incomplete type
>    93 |         HMAC_CTX ctx;
>       |                  ^~~
> 
> Add a patch, sent upstream, to only use libatomic if linking against it
> makes the 64-bit atomics test pass.
> 
> This issue has been present since commit 20c3eb6eb684
> ("package/libwebsockets: bump version to 4.5.7"), which bumped
> libwebsockets from 4.4.1 to 4.5.7, the atomic check having been added
> in 4.5.3. It therefore affects 2026.05 and later.
> 
> Fixes:
> https://autobuild.buildroot.org/results/863c30265623973e15a25c2d38c0e1631a39b7e8
> 
> Fixes: 20c3eb6eb68432c37d5db69963be266b7f2d23f7 ("package/libwebsockets: bump version to 4.5.7")
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>

Applied to master, thanks!

Best regards,

Thomas Petazzoni
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2026-10-27 16:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-27  8:16 [Buildroot] [PATCH] package/libwebsockets: fix OpenSSL detection without libatomic Yegor Yefremov
2026-10-27 16:09 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auDMmNNMbgZTC16s@windsurf \
    --to=buildroot@buildroot.org \
    --cc=danomimanchego123@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yegorslists@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.