From: Niklas Cassel <cassel@kernel.org>
To: Giuseppe Piscitelli <ooonea@gmail.com>
Cc: Damien Le Moal <dlemoal@kernel.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: libata-core: Check device support before querying power state
Date: Tue, 27 Oct 2026 21:29:33 +0100 [thread overview]
Message-ID: <auEJrdh5CfpJoFdj@ryzen> (raw)
In-Reply-To: <20261026202513.669084-1-ooonea@gmail.com>
On Mon, Oct 26, 2026 at 09:25:11PM +0100, Giuseppe Piscitelli wrote:
> The standby path queries the power state before checking whether the
> device accepts ATA power-management commands. This sends CHECK POWER MODE
> to ATAPI devices, including the QEMU DVD-ROM, which rejects it.
>
> Run the existing taskfile initialization and device-class check first,
> as the active-power path already does.
>
> Fixes: 9cec467d0502 ("ata: libata-core: Do not call ata_dev_power_set_standby() twice")
> Signed-off-by: Giuseppe Piscitelli <ooonea@gmail.com>
> ---
Reviewed-by: Niklas Cassel <cassel@kernel.org>
prev parent reply other threads:[~2026-10-27 20:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 20:25 [PATCH] ata: libata-core: Check device support before querying power state Giuseppe Piscitelli
2026-10-27 20:29 ` Niklas Cassel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auEJrdh5CfpJoFdj@ryzen \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ooonea@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.