From: Keith Busch <kbusch@kernel.org>
To: Guixin Liu <kanie@linux.alibaba.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
Nilay Shroff <nilay@linux.ibm.com>,
Daniel Wagner <dwagner@suse.de>, Hannes Reinecke <hare@suse.de>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH v3] nvme-tcp: Validate the queue state under the queue lock in the address attribute
Date: Tue, 27 Oct 2026 17:20:45 -0600 [thread overview]
Message-ID: <auExzRCjbyQeOU78@kbusch-mbp> (raw)
In-Reply-To: <20261027123950.3122316-1-kanie@linux.alibaba.com>
On Tue, Oct 27, 2026 at 08:39:50PM +0800, Guixin Liu wrote:
> @@ -3035,6 +3048,14 @@ static struct nvme_tcp_ctrl *nvme_tcp_alloc_ctrl(struct device *dev,
> goto out_free_ctrl;
> }
>
> + /*
> + * The queue locks are owned by the controller, not the queues:
> + * they outlive the per-queue connect/disconnect cycles so that
> + * sysfs readers can never race their destruction.
> + */
> + for (i = 0; i < ctrl->ctrl.queue_count; i++)
> + mutex_init(&ctrl->queues[i].queue_lock);
> +
Could you rebase to the latest nvme-7.4 branch? There is already a loop
happening here to initialize other fields in the queue.
next prev parent reply other threads:[~2026-10-27 23:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 12:39 [PATCH v3] nvme-tcp: Validate the queue state under the queue lock in the address attribute Guixin Liu
2026-10-27 13:04 ` Nilay Shroff
2026-10-27 23:20 ` Keith Busch [this message]
2026-10-28 2:03 ` Guixin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auExzRCjbyQeOU78@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kanie@linux.alibaba.com \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.