From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: Venkat Ragavan via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Karthik Nayak <karthik.188@gmail.com>,
Harald Nordgren <haraldnordgren@gmail.com>,
"D. Ben Knoble" <ben.knoble@gmail.com>,
Venkat Ragavan <mail2venkat21@gmail.com>
Subject: Re: [PATCH] refs: fix loose-ref seeking across directory boundaries
Date: Wed, 28 Oct 2026 09:58:29 +0100 [thread overview]
Message-ID: <auG5NTowgVZG9L2Q@pks.im> (raw)
In-Reply-To: <xmqqzevyg4w7.fsf@gitster.g>
On Tue, Oct 27, 2026 at 03:22:48PM -0700, Junio C Hamano wrote:
> "Venkat Ragavan via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > From: Venkat Ragavan S <mail2venkat21@gmail.com>
> >
> > When seeking through loose refs, cache_ref_iterator_seek() compares
> > each directory component without its trailing slash. This can confuse
> > a directory with a similarly named ref that sorts before it.
> > ...
> > Add regression tests for shared-prefix names, missing nested markers,
> > and markers beyond the end of the ref listing, using loose, packed,
> > and mixed refs.
> >
> > Signed-off-by: Venkat Ragavan S <mail2venkat21@gmail.com>
> > ---
> > refs: fix loose-ref seeking across directory boundaries
>
> I overlooked this topic, but re-reading the discussion, aside from a
> test that confused a reader, it seems the topic was already ready to
> go?
>
> Any objections to the idea of making the topic ready for 'next'?
Sorry, I lost track of this patch series, but I've reviewed it now.
Overall this looks good, but I wonder whether this really should be
split up into three patches because as far as I understand, this single
patch solves three separate bugs at once.
Patrick
next prev parent reply other threads:[~2026-10-28 8:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 12:30 [PATCH] refs: fix loose-ref seeking across directory boundaries Venkat Ragavan via GitGitGadget
2026-10-15 13:36 ` Harald Nordgren
2026-10-15 17:08 ` D. Ben Knoble
[not found] ` <CAFuK-oaFyp7QdA=Nrc68cNx1iu803pQSUOZ=f947rRjWbJ7Z5w@mail.gmail.com>
2026-10-15 19:04 ` D. Ben Knoble
2026-10-15 19:13 ` Junio C Hamano
2026-10-15 21:17 ` Harald Nordgren
[not found] ` <CAFuK-obau8UkmVVs0xkuwjddkqftMxwcGnGR640YqjswGrTj3Q@mail.gmail.com>
2026-10-16 3:19 ` Venkat Ragavan
2026-10-27 22:22 ` Junio C Hamano
2026-10-28 8:58 ` Patrick Steinhardt [this message]
2026-10-28 16:26 ` Junio C Hamano
2026-10-28 8:57 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auG5NTowgVZG9L2Q@pks.im \
--to=ps@pks.im \
--cc=ben.knoble@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=haraldnordgren@gmail.com \
--cc=karthik.188@gmail.com \
--cc=mail2venkat21@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.