From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Olivier Louvignes <olivier@mgcrea.io>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Paul Cercueil" <paul@crapouillou.net>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: adc: Add a driver for the Ingenic X1600 ADC
Date: Wed, 28 Oct 2026 08:16:01 +0100 [thread overview]
Message-ID: <auGg1AwlHMTKYAL8@monoceros> (raw)
In-Reply-To: <20261023204209.48556-2-olivier@mgcrea.io>
[-- Attachment #1: Type: text/plain, Size: 417 bytes --]
Hello,
On Fri, Oct 23, 2026 at 10:42:09PM +0200, Olivier Louvignes wrote:
> +#include <linux/mod_devicetable.h>
> [...]
> +#include <linux/platform_device.h>
Please don't include <linux/mod_devicetable.h>,
<linux/platform_device.h> already provides of_device_id without all the
added build dependencies of <linux/mod_devicetable.h>. If you insist on
full iwyu, use <linux/device-id/of.h> instead.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-10-28 7:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 20:42 [PATCH 1/2] dt-bindings: iio: adc: Add the Ingenic X1600 ADC Olivier Louvignes
2026-10-23 20:42 ` [PATCH 2/2] iio: adc: Add a driver for " Olivier Louvignes
2026-10-24 1:44 ` Jonathan Cameron
2026-10-28 7:16 ` Uwe Kleine-König [this message]
2026-10-24 17:17 ` [PATCH 1/2] dt-bindings: iio: adc: Add " H. Nikolaus Schaller
2026-10-27 17:47 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auGg1AwlHMTKYAL8@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=olivier@mgcrea.io \
--cc=paul@crapouillou.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.