All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <tom.leiming@gmail.com>
To: Yoav Cohen <yoav@nvidia.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, csander@purestorage.com,
	jholzman@nvidia.com, omril@nvidia.com, ofer@nvidia.com
Subject: Re: [PATCH v4 1/2] ublk: honor rq_affinity on request completion
Date: Wed, 28 Oct 2026 09:43:51 -0500	[thread overview]
Message-ID: <auIKJ0CucMnDEMiQ@fedora-laptop> (raw)
In-Reply-To: <20261028131829.45803-2-yoav@nvidia.com>

On Wed, Oct 28, 2026 at 03:18:28PM +0200, Yoav Cohen wrote:
> ublk completes requests inline on the server thread, so rq_affinity has
> no effect: completion work always runs on the server's CPU instead of
> the submitter's, unlike NVMe and other drivers.
> 
> Add UBLK_F_SUPPORT_RQ_AFFINITY. If the server sets it, a request that
> completed in full is passed to blk_mq_complete_request_remote() and
> ended from ->complete(), unless rq_affinity is 0. Partial completions
> and errors still complete inline.
> 
> Servers that don't set the flag see no change.
> 
> Signed-off-by: Yoav Cohen <yoav@nvidia.com>

Reviewed-by: Ming Lei <tom.leiming@gmail.com>

Thanks,
Ming

  reply	other threads:[~2026-10-28 14:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-28 13:18 [PATCH v4 0/2] ublk: honor rq_affinity on request completion Yoav Cohen
2026-10-28 13:18 ` [PATCH v4 1/2] " Yoav Cohen
2026-10-28 14:43   ` Ming Lei [this message]
2026-10-28 13:18 ` [PATCH v4 2/2] selftests: ublk: add rq_affinity test Yoav Cohen
2026-10-28 14:44   ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auIKJ0CucMnDEMiQ@fedora-laptop \
    --to=tom.leiming@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=csander@purestorage.com \
    --cc=jholzman@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    --cc=ofer@nvidia.com \
    --cc=omril@nvidia.com \
    --cc=yoav@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.