From: "Roger Pau Monné" <roger@xenproject.org>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Teddy Astie <teddy.astie@vates.tech>
Subject: Re: [PATCH v2 5/5] x86/vMSI: avoid "goto" in msixtbl_pt_unregister()
Date: Wed, 28 Oct 2026 15:51:12 +0100 [thread overview]
Message-ID: <auIL4OH2DQZ1F9iU@Mac.lan> (raw)
In-Reply-To: <3f19c5e9-d8d2-4752-99a1-b5115c3c862b@suse.com>
On Wed, Sep 30, 2026 at 01:43:59PM +0200, Jan Beulich wrote:
> "goto" can be helpful in certain situations, yet where easily possible I
> think it's better to avoid its use. With the re-arrangement also restrict
> the scop of two of the local variables, and add const to one of them.
>
> No functional changed intended.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Roger Pau Monné <roger@xenproject.org>
Thanks, Roger.
prev parent reply other threads:[~2026-10-28 14:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 11:40 [PATCH v2 0/5] x86: pass-through / {,v}PCI locking Jan Beulich
2026-09-30 11:42 ` [PATCH v2 1/5] x86/pass-through: alter locking around pt_irq_{create,destroy}_bind() Jan Beulich
2026-10-28 14:33 ` Roger Pau Monné
2026-10-28 15:21 ` Jan Beulich
2026-10-28 15:36 ` Roger Pau Monné
2026-09-30 11:42 ` [PATCH v2 2/5] x86/vPCI: tighten locking assertions Jan Beulich
2026-09-30 11:43 ` [PATCH v2 3/5] x86/pass-through: use simpler locking primitives in pt_irq_{create,destroy}_bind() Jan Beulich
2026-09-30 11:43 ` [PATCH v2 4/5] x86/vPCI: make better use of "pdev" in vpci_msix_arch_print() Jan Beulich
2026-10-28 14:38 ` Roger Pau Monné
2026-09-30 11:43 ` [PATCH v2 5/5] x86/vMSI: avoid "goto" in msixtbl_pt_unregister() Jan Beulich
2026-10-28 14:51 ` Roger Pau Monné [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auIL4OH2DQZ1F9iU@Mac.lan \
--to=roger@xenproject.org \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=teddy.astie@vates.tech \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.