Re: [PATCH] xfs: fix bs_xflags copied from wrong compat field

[Christoph Hellwig <hch@infradead.org>]

On Tue, Oct 27, 2026 at 11:26:09AM -0500, Eric Sandeen wrote:
> On 10/27/26 10:18 AM, Christoph Hellwig wrote:
> > I wonder if we should have a way to test these compat abis in
> > xfstests.  Have test programs (or xfs_io?) compiled with -m32
> > and compare to native?
> What about 2 things:
> 
> A refactor (to eliminate the need to type out matching structure names twice)
> and a kunit test?

I don't think kunit is all that helpful for copy to/from user tests..

> Something like:
> 
> #define BSTAT_GET(f)            (bstat->f = bstat32->f)
> 
> xfs_bstat_from_compat(
>         struct xfs_bstat                *bstat,
>         const struct compat_xfs_bstat   *bstat32)
> {
> 	BSTAT_GET(bs_ino);
> 	BSTAT_GET(bs_mode);
> 	BSTAT_GET(bs_nlink);
> 	...
> }

That makes the code so much harder to read for no real gain.