From: Yury Norov <ynorov@nvidia.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Yury Norov <yury.norov@gmail.com>
Subject: Re: [PATCH] lockdep: Add #include <linux/instruction_pointer.h> to lockdep.h
Date: Wed, 28 Oct 2026 11:48:16 -0400 [thread overview]
Message-ID: <auIZQDojrrv43MrA@yury> (raw)
In-Reply-To: <20261028114528.137acd81@gandalf.local.home>
On Wed, Oct 28, 2026 at 11:45:28AM -0400, Steven Rostedt wrote:
> On Wed, 28 Oct 2026 11:16:05 -0400
> Yury Norov <ynorov@nvidia.com> wrote:
>
> > On Wed, Oct 28, 2026 at 11:05:58AM -0400, Steven Rostedt wrote:
> > > From: Steven Rostedt <rostedt@goodmis.org>
> > >
> > > On 32bit x86, _THIS_IP_ is not defined in asm/linkage.h. It happens to get
> > > included into lockdep.h via kernel.h pulling in trace_printk.h which
> > > includes instruction_pointer.h that has _THIS_IP_ defined when linkage.h
> > > does not.
> > >
> > > In order to remove trace_printk.h from kernel.h, have lockdep.h include
> > > instruction_pointer.h directly.
> > >
> > > Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
> >
> > Reviewed-by: Yury Norov <yury.norov@gmail.com>
>
> Thanks Yury.
>
> Peter, can you give me an Acked-by on this patch and then I can add it to
> my series to remove trace_printk.h from kernel.h as that depends on this
> patch.
Steven, can you share a link to the series?
next prev parent reply other threads:[~2026-10-28 15:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 15:05 [PATCH] lockdep: Add #include <linux/instruction_pointer.h> to lockdep.h Steven Rostedt
2026-10-28 15:16 ` Yury Norov
2026-10-28 15:45 ` Steven Rostedt
2026-10-28 15:48 ` Yury Norov [this message]
2026-10-28 16:30 ` Steven Rostedt
2026-10-28 17:54 ` Yury Norov
2026-10-28 18:05 ` Steven Rostedt
2026-10-29 8:34 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auIZQDojrrv43MrA@yury \
--to=ynorov@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.