All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 Jiri Slaby <jirislaby@kernel.org>,
	linux-serial@vger.kernel.org, linux-input@vger.kernel.org,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Input: serport - defer write wakeups to a worker
Date: Wed, 28 Oct 2026 10:09:57 -0700	[thread overview]
Message-ID: <auIsPu4hA0f1SpRX@google.com> (raw)
In-Reply-To: <20261028-submit-serport-write-wakeup-v1-v2-1-c05d96259985@gmail.com>

Hi James,

On Wed, Oct 28, 2026 at 01:14:19AM -0600, James Hilliard wrote:
> @@ -54,6 +56,11 @@ static int serport_serio_open(struct serio *serio)
>  	guard(spinlock_irqsave)(&serport->lock);

I changed this to scoped_guard() and applied.

>  	set_bit(SERPORT_ACTIVE, &serport->flags);
>  
> +	if (serio->drv->write_wakeup) {
> +		enable_work(&serport->write_wakeup);
> +		set_bit(TTY_DO_WRITE_WAKEUP, &serport->tty->flags);
> +	}
> +
>  	return 0;
>  }

Thanks.

-- 
Dmitry

      parent reply	other threads:[~2026-10-28 17:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-28  7:14 [PATCH v2] Input: serport - defer write wakeups to a worker James Hilliard
2026-10-28  7:23 ` sashiko-bot
2026-10-28 17:09 ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auIsPu4hA0f1SpRX@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=james.hilliard1@gmail.com \
    --cc=jirislaby@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.