From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.217.52 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793209470; b=Ai3TkbNn/0oG59GFOGBXuAKmDzPEf+bK8BfjhsYtrEbIOuplDK7gabUQHTrfP2KYnMLF wHcyWdb6Qw7C2JWoIJLDb0uWruaHrDL++j31gM9gvI8KtmaIBiWf1uY4qbl3C9FsEaRq8 SvviNBAm71soGlG0iJRO1Ops9w1B3fq0tAjBfo65bNP0LkPC+EbWb38D2RTo+2z5jpdJG pS9y2lE0/94eaChfBaiMeVYc5LcZ52qIOMKrEVrqvHN7mZ83E2YBpcaqsbypNzR0SrjUm Luwkqq9RZo17Qy83NuGi2Xbuv3zbd3MxkVNYm1ILTFl35F7C1GeBjKvQsnkJ14WNX8Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793209470; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:Content-Transfer-Encoding: In-Reply-To; bh=s56cw49H74YOeay3n+CLmJxr96H3PjfrjsaPdtr6E80=; b=4hQSr3jQLhlqkusAhtdhbq65gtnykgswubZr1AQWjV4W1eJmfmXzcPGH3y6JNQcJWlo8 3xGJZr+Fn+a4785P98ehUh5BiKN2qcXFeG/eEX5rLMQSwk3n/729ejP6AHF0aXkbNBqXr R9ryCQF4T46Og9kA+kRXW5i9SoG7aBa+ABeD8rha/sEjPK7p5O4+aFaeYkV7I1b4wmuDb kAvw4zvyR+yxhAbOxbg+6uSXxAcXeB0WScRMGlTOT+HGs2GCLHN2STk/l5WaCh3sJCYlj R38PdEUdvW/TMWqg/bssh2EiDabMLOsmSMnG5TV3EI+xWpn4uLfETB1CnJjrv79HeOQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=soleen.com; spf=pass smtp.mailfrom=soleen.com; dkim=pass header.d=soleen.com header.i=@soleen.com header.a=rsa-sha256 header.s=google header.b=iJy5kuJI; arc=none smtp.remote-ip=209.85.217.52 Received: from mail-vs1-f52.google.com (mail-vs1-f52.google.com [209.85.217.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 731C1606A321 for ; Wed, 28 Oct 2026 17:44:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 731C1606A321 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=soleen.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=soleen.com header.i=@soleen.com header.a=rsa-sha256 header.s=google header.b=iJy5kuJI Received: by mail-vs1-f52.google.com with SMTP id ada2fe7eead31-7cc91ddf447so483241137.2 for ; Wed, 28 Oct 2026 10:44:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1793209469; x=1793814269; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=s56cw49H74YOeay3n+CLmJxr96H3PjfrjsaPdtr6E80=; b=iJy5kuJIKEFoVGXIv0G1W+lcBvi4+8Xg3Up72eyRWsM34ppCddP5ilpekezxnMXx54 wNVtglNWl1Juw56jX8SNwQS7WZKs9Y2X61a375wMFfYgiH4i03Atn7I+ij8S+kLhqtfT l07FNZinyoqAk6s+eVtDRNFkKCg8ONt5X560obpxpG2ZC7VnPvjzuP7bhaeVMMRQaZQf bnvIZGVN+qVBNlncKqiFZBQ2j+79seozjiyPSZgLY1TuGDnPTDoB10ATDbxfyjixqlJz vdOfv2Qybh76j3dxSW1ILlTknOlei2s6oL7+i6Y7LDLEJWeTZKkbkP+obWZ+cP33y8/P 9s8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793209469; x=1793814269; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=s56cw49H74YOeay3n+CLmJxr96H3PjfrjsaPdtr6E80=; b=kFFtG8bDpgbqOpXLAL2aU6Rr8Bn89Nj8x9gzCZSsadeEfM9lJf1VUVaxlNeD1k1/tR qUKMROQUReGsRDmQr1xAibyNnqYvQKR3vtDpr/ItyNixwDALEleMGzLyRbZPlOZrmTdb Znin+34szX550FL/oU5WtxISas/0SR0f54gF2amJ4D0sZkriOhB+5AM547YN+aKXQVVZ HDvkBVJxMrx2EB3rd+PXhjG2Zq51F9qCANe5kfXfCOPXkW0vcWomYttFsH4uqRedSxRp Vl8rfkW+ogGM9I+PIgtFL6WzacogD8f1sWgxhWw1W1AQmX68R5Y78yDporfm+Fge+jUp 97LQ== X-Forwarded-Encrypted: i=1; AKwUvBxrjv7FmljjVUptmMmejncKX++hc+4B3dNRZQYx3T7TCrBNZsNm+PFjcvzf1xo2tXbHf7k=@vger.kernel.org X-Gm-Message-State: AFq9FYJbHP2TELMSJXA2Vi7vKEVOlCKwRelTsjjOhaXuH8Kaj4OL3rgx 3xgDvOJk87OjVUDf75vnDDLNZBv66Ds4USYy9oS69Xi4fBsl+U4IeMuZ3gBJBs+9MWI= X-Gm-Gg: AYBFou0FAKX7F19CO8Z+AdiaoT1wT3XOElccn5C9gOZ+heTnOTZjaHBFR177n57Vu4y ik/cvCGtZWw5jpHs56P1sSG45QqNUd+p3Z4G5E1dk9+isa5zqy2EoQGs3uGPF//ZIZtnrH8NlUo tYqOnVaclByHMqxBivJJWX6t/FNHO+Vn7haBJZ2up/3Qcr64i7crQeyWI8PfcZTVNKlMGCc3PDe dQoMa+PhGUsCpic2VPztZaDGTNURX1Pf/LmTIzU/ZgQsaY3WJxaOo6WNQZiadW8iRUVCuxJ5VsF kQRAy+fLXf8Y/gXxXzCQQcXwl98UVbk6KUnpCXKxYK3tzdYTz+caXGX1xC91XPuL6cY3HE3BBQ6 MLw7HiMVfbgxkYhROH9L1U090iCs2jK4cYzdPzyjZQWW+eGjDJVOCxjbeHRQKCUDBmDFVTkyM9V Ne85EUTzfp8NlP90HRlelQl65xXaWGC8djdLJiYt1AUI+IDo5/EKidvKEbhbRvo2XPH9Nh3eRbm 2/kCyZUX1lQwbUkPOUEl66bCjvddMadhPFGiJQT3G8qcoC0eRjeQvKs7XQLb+Oj//umQKIIJl8+ Dsljj9pNokuvj3Wp8Sh5tMKIpV8+oaBfVR6mySVnXNwe1yFXb2JirJIxaYCuKrEVGykIEzmMIBp Wf/uygZIhnVcG1ifqbdwe3Uz2K7OBkT8T X-Received: by 2002:a05:6102:3e8d:b0:7a5:7282:1994 with SMTP id ada2fe7eead31-7d03a50a85cmr1269510137.7.1793209468986; Wed, 28 Oct 2026 10:44:28 -0700 (PDT) Received: from google.com (64.167.245.35.bc.googleusercontent.com. [35.245.167.64]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-99125931983sm6616412241.2.2026.10.28.10.44.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2026 10:44:28 -0700 (PDT) Date: Wed, 28 Oct 2026 13:44:27 -0400 From: Pasha Tatashin To: Pratyush Yadav Cc: David Matlack , Pasha Tatashin , tarunsahu@google.com, Andrew Morton , joro@8bytes.org, Mike Rapoport , maz@kernel.org, arnd@arndb.de, jgg@nvidia.com, robin.murphy@arm.com, loganodell@google.com, oupton@kernel.org, kevin.tian@intel.com, alex@shazbot.org, dwmw2@infradead.org, pbonzini@redhat.com, seanjc@google.com, will@kernel.org, Alexander Graf , Bjorn Helgaas , baolu.lu@linux.intel.com, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, sagis@google.com, linux-mm@kvack.org, kvmarm@lists.linux.dev, iommu@lists.linux.dev, linux-pci@vger.kernel.org, kexec@lists.infradead.org, skhawaja@google.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 3/4] liveupdate: Replace compatibility string with a 2-bit pair feature header Message-ID: References: <2vxz8q3hoicx.fsf@kernel.org> X-Mailing-List: kvm@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2vxz8q3hoicx.fsf@kernel.org> On 10-28 18:17, Pratyush Yadav wrote: > On Mon, Oct 26 2026, David Matlack wrote: > > > On 2026-10-25 04:38 PM, Pasha Tatashin wrote: > >> On Fri, Oct 23, 2026 at 9:50 AM David Matlack wrote: > > > [...] > >> The reason I care about keeping the header compact is that we are > >> defining a foundational kernel ABI and want to use this header across > >> almost every serialized data structure so we can evolve them later > >> without breaking compatibility. While some top-level structs are on > >> sparse folios today, other serialized structs are tightly packed, and > >> we are looking to add KHO slab support in the future where tightly > >> packed allocations will be common. > > > > My intuition is we will have a small number of headers per preserved > > file and per preserved FLB. One for the top-level struct and then > > optionally a few more for sub-structs like arch-specific data. That is > > why I am less worried 8 bytes per header, even if we fix the folio > > problem. > > > > Maybe where our visions differ is when there are collections of > > serialized structs, like KHO blocks. For collections I don't think the > > elements will each have their own headers. Otherwise the elements could > > be different sizes. > > kho_block today doesn't store entry_size in the serialized payload. It > relies on its caller to do so. With extensible structures, this can get > messy. Sure, the owner of the kho_block_set can track the size somewhere > in its payload, but perhaps we should store the size in > kho_block_header_ser to begin with? I agree, and we will discuss versioned vs. owned serialized data structures separately. With this series, we establish a common framework: size/feature flags and accessors, and we update most of our serialized structs to include them. All "shared" structs (e.g., KHO, FLB, radix-tree, block_sets, etc.) should have their own versioning. kho_block_header_ser should have this header. Pasha > > Anyway, not a problem this series needs to solve, but something we > should eventually do. > > [...] > > -- > Regards, > Pratyush Yadav