From: Jarkko Sakkinen <jarkko@kernel.org>
To: Stefano Radaelli <stefano.radaelli21@gmail.com>
Cc: linux-kernel@vger.kernel.org, pierluigi.p@variscite.com,
Stefano Radaelli <stefano.r@variscite.com>,
Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org
Subject: Re: [PATCH v1 1/1] tpm: tis_i2c: Add reset delays for ST33KTPM2XI2C
Date: Wed, 28 Oct 2026 22:32:49 +0200 [thread overview]
Message-ID: <auJb8drL7rpvNMyK@kernel.org> (raw)
In-Reply-To: <20261028094504.4256-1-stefano.r@variscite.com>
On Wed, Oct 28, 2026 at 10:45:04AM +0100, Stefano Radaelli wrote:
> From: Stefano Radaelli <stefano.r@variscite.com>
>
> The optional reset control is deasserted without a delay, and probe then
> proceeds directly to the first I2C register access. Since reset-gpio
> initializes its line asserted, this provides no guaranteed minimum reset
> pulse width or recovery interval before communication starts.
>
> Table 66 of the ST33KTPM-IDevID datasheet specifies a minimum reset pulse
> width of 1 ms and up to 50 ms from reset release before the first command.
> Choose a 2 ms assertion interval to provide margin above the minimum and
> wait 50 ms after deassertion, before initializing the I2C guard times.
>
> Associate these timings with the existing st,st33ktpm2xi2c compatible using
> match data. Apply the delays only when a reset control is present. Preserve
> the existing deassert-only sequence and the behavior of devices without
> timing data or a reset control, without adding Device Tree properties.
"Pull the timings from the matched device entry. If they don't exist,
fall back to the legacy behavior without delays. Update of_tis_i2c_match
with the timings for st33ktpm2xi2c."
I.e. the last paragraph has the language of a white paper.
Br, Jarkko
next prev parent reply other threads:[~2026-10-28 20:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 9:45 [PATCH v1 1/1] tpm: tis_i2c: Add reset delays for ST33KTPM2XI2C Stefano Radaelli
2026-10-28 20:32 ` Jarkko Sakkinen [this message]
2026-10-29 9:47 ` Stefano Radaelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auJb8drL7rpvNMyK@kernel.org \
--to=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=pierluigi.p@variscite.com \
--cc=stefano.r@variscite.com \
--cc=stefano.radaelli21@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.