Re: [PATCH v2 1/4] fdtput: Require a leading '/' with -p

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 2047 bytes --]

On Wed, Oct 28, 2026 at 09:14:49PM +0100, Herve Codina wrote:
> On Wed, 28 Oct 2026 01:34:17 -0600
> Simon Glass <sjg@chromium.org> wrote:
> 
> > With -p, a path which does not start with '/' is created from the root,
> > so a mistyped path silently adds nodes at the top level:
> > 
> >    $ fdtput -cp test.dtb foo/bar
> > 
> > This creates /foo/bar. The same happens for a path which starts with an
> > alias, such as serial0/sub, which creates /serial0/sub rather than
> > adding to the node which the alias points to.
> > 
> > Without -p, fdtput rejects such a path, since fdt_path_offset() treats a
> > path without a leading '/' as starting with an alias:
> > 
> >    $ fdtput -c test.dtb foo/bar
> >    Error at 'foo': FDT_ERR_BADPATH
> > 
> > Report an error with -p too. The next patch allows such a path to start
> > with an alias.
> 
> I would reword "The next patch allows" using "A future patch could allow" or
> I would simply remove the whole sentence ("The next patch ...");

As a rule, that is a better way of phrasing a commit message, so that
it doesn't become inaccurate if this are reordered.  In this case it's
not worth a respin, though.

> 
> Indeed, this current patch can be applied without the next one.
> 
> Other than that:
> Reviewed-by: Herve Codina <herve.codina@bootlin.com>
> 
> Best regards,
> Hervé
> 
> > 
> > This changes the behaviour of -p, so a script which relies on creating
> > nodes this way must add a leading '/'. Do this for the existing test
> > which relies on it, and add a test for the error.
> > 
> > Fixes: f807af192828 ("fdtput: Add -p option to create subnodes along entire path")
> > Suggested-by: David Gibson <david@gibson.dropbear.id.au>
> > Assisted-by: Claude:claude-opus-5-5
> > Signed-off-by: Simon Glass <sjg@chromium.org>
> > ---
> 

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]