From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 761B7606A31C for ; Thu, 29 Oct 2026 10:49:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=F0qQh5Br Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xMNh4-0002c5-Sd; Thu, 29 Oct 2026 06:49:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xMNgy-0002Zh-UP for qemu-devel@nongnu.org; Thu, 29 Oct 2026 06:49:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xMNgw-00071m-CO for qemu-devel@nongnu.org; Thu, 29 Oct 2026 06:49:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1793270945; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f7mNSnrpobAXCFKfPjSCg2XHMc2cWT71Eb6kY2qUcwg=; b=F0qQh5BrvbW2xcgE7P9gVYMqjYGW9FJyEnpVVqrQPeSKRIfdTVq8oTiVaODSspct6uA0Ya 1AdqTdH2yHGEpiPWZJrJHg6FYlDMzHEAQaFuizVwkyiRitbvYMiZCqFOUqDRjeY1YMDphk dUwFkRIDzr1KFUX4Xr+qXWYF4ABg/wI= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-593-6Fk5PjolOKuSJvjRjadrAA-1; Thu, 29 Oct 2026 06:49:03 -0400 X-MC-Unique: 6Fk5PjolOKuSJvjRjadrAA-1 X-Mimecast-MFC-AGG-ID: 6Fk5PjolOKuSJvjRjadrAA_1793270942 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B3ABB1800366 for ; Thu, 29 Oct 2026 10:49:02 +0000 (UTC) Received: from redhat.com (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F25C51800480; Thu, 29 Oct 2026 10:49:01 +0000 (UTC) Date: Thu, 29 Oct 2026 10:48:59 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Markus Armbruster Cc: qemu-devel@nongnu.org Subject: Re: [PATCH 4/8] qapi: drop CompatPolicySecurity and use CompatPolicyInput Message-ID: References: <20261028133603.1893289-1-berrange@redhat.com> <20261028133603.1893289-5-berrange@redhat.com> <875wylghh1.fsf@pond.sub.org> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <875wylghh1.fsf@pond.sub.org> User-Agent: Mutt/2.4.2 (2026-08-30) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, GB_FAKE_RF=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Thu, Oct 29, 2026 at 07:15:38AM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > With CompatPolicyInput gaining a "warn" option, the CompatPolicySecurity > > type is redundant. > > > > Note the error message for insecure-input changes from > > > > Type 'rtl8139' does not provide a security boundary > > to protect against untrusted data or actions > > > > To > > > > Insecure QOM type rtl8139 disabled by policy > > This loses a bit of information. Do we care? I show a way to retain it > below. > > > > > Signed-off-by: Daniel P. Berrangé > > --- > > qapi/compat.json | 18 +----------------- > > qapi/qapi-util.c | 21 ++++----------------- > > 2 files changed, 5 insertions(+), 34 deletions(-) > > > > diff --git a/qapi/compat.json b/qapi/compat.json > > index f28c24149c8..7790a7896a8 100644 > > --- a/qapi/compat.json > > +++ b/qapi/compat.json > > @@ -37,22 +37,6 @@ > > { 'enum': 'CompatPolicyOutput', > > 'data': [ 'accept', 'hide' ] } > > > > -## > > -# @CompatPolicySecurity: > > -# Policy for handling any devices or backends which do not provide > > -# a security boundary to protect against untrusted environments > > -# > > -# @accept: Allow any usage > > -# > > -# @reject: Reject with an error reported > > -# > > -# @warn: Allow any usage, with a warning reported > > -# > > -# Since: 11.2 > > -## > > -{ 'enum': 'CompatPolicySecurity', > > - 'data': [ 'accept', 'reject', 'warn' ] } > > - > > ## > > # @CompatPolicy: > > # Policy for handling deprecated management interfaces. > > @@ -87,4 +71,4 @@ > > '*deprecated-output': 'CompatPolicyOutput', > > '*unstable-input': 'CompatPolicyInput', > > '*unstable-output': 'CompatPolicyOutput', > > - '*insecure-input': 'CompatPolicySecurity' } } > > + '*insecure-input': 'CompatPolicyInput' } } > > This adds policy value "crash", doesn't it? The commit message should > mention it. Ok > > > diff --git a/qapi/qapi-util.c b/qapi/qapi-util.c > > index e6f3006b16c..36926b5003d 100644 > > --- a/qapi/qapi-util.c > > +++ b/qapi/qapi-util.c > > @@ -72,23 +72,10 @@ bool compat_policy_check_security(const CompatPolicy *policy, > > return true; > > } > > > > - switch (policy->insecure_input) { > > - case COMPAT_POLICY_SECURITY_ACCEPT: > > - return true; > > - > > - case COMPAT_POLICY_SECURITY_REJECT: > > - error_setg(errp, "Type '%s' does not provide a security boundary " > > - "to protect against untrusted data or actions", typename); > > - return false; > > - > > - case COMPAT_POLICY_SECURITY_WARN: > > - warn_report("Type '%s' does not provide a security boundary " > > - "to protect against untrusted data or actions", typename); > > - return true; > > - > > - default: > > - g_assert_not_reached(); > > - } > > + return compat_policy_input_ok1(policy->insecure_input, > > + "Insecure", > > + ERROR_CLASS_GENERIC_ERROR, > > + "QOM type", typename, errp); > > } > > ... then try something like this: > > if (!compat_policy_input_ok1(...) { > error_append_hint(errp, ...); > } > > Don't forget ERRP_GUARD() then, error_append_hint() needs it. Yep, that's a nice idea. With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|