All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Garzarella <sgarzare@redhat.com>
To: Tim Pambor <timpambor@gmail.com>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Kevin Wolf" <kwolf@redhat.com>,
	"Hanna Reitz" <hreitz@redhat.com>,
	"Jason Wang" <jasowangio@gmail.com>,
	"Pierrick Bouvier" <pierrick.bouvier@oss.qualcomm.com>,
	qemu-block@nongnu.org, "Raphael Norwitz" <rnorwitz@nvidia.com>,
	"Brad Smith" <brad@comstyle.com>
Subject: Re: [PATCH 8/8] libvhost-user: detect memfd support with a link test
Date: Thu, 29 Oct 2026 12:44:18 +0100	[thread overview]
Message-ID: <auMwF2bb4bHLLuwB@sgarzare-redhat> (raw)
In-Reply-To: <20261022-vhost-user-posix-v1-8-0bd4d450d23c@gmail.com>

On Thu, Oct 22, 2026 at 03:47:29PM +0200, Tim Pambor wrote:
> The inflight fd code is guarded by #ifdef MFD_ALLOW_SEALING, which only
> tells us that the headers define the flag, not that memfd_create() is
> available in the C library. There are environments where the flag is
> defined but the link fails:
> 
>   ld: error: libvhost-user.a(libvhost-user.c.o): undefined symbol: memfd_create
> 
> Probe for memfd_create() with MFD_ALLOW_SEALING in the subproject's
> meson.build, using the same test QEMU's top-level meson.build uses for
> CONFIG_MEMFD, and guard the code with CONFIG_MEMFD instead.
> 
> When memfd is not available, VHOST_USER_PROTOCOL_F_INFLIGHT_SHMFD is
> masked out as before, so the frontend never sends
> VHOST_USER_GET_INFLIGHT_FD.
> 
> Signed-off-by: Tim Pambor <timpambor@gmail.com>
> ---
>  subprojects/libvhost-user/libvhost-user.c | 17 ++++++++---------
>  subprojects/libvhost-user/meson.build     | 11 ++++++++++-
>  2 files changed, 18 insertions(+), 10 deletions(-)

Should we move this commit before we enable libvhost-user on any POSIX?

Also, maybe we should do something similar for CONFIG_EVENTFD as I 
pointed out in the other commit.

Thanks,
Stefano



  reply	other threads:[~2026-10-29 11:45 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-22 13:47 [PATCH 0/8] vhost-user: another try at supporting any POSIX system Tim Pambor
2026-10-22 13:47 ` [PATCH 1/8] vhost-user: kick via event_notifier_set() Tim Pambor
2026-10-29 11:43   ` Stefano Garzarella
2026-10-22 13:47 ` [PATCH 2/8] libvhost-user: self-kick through a library-owned notifier Tim Pambor
2026-10-29 11:43   ` Stefano Garzarella
2026-10-22 13:47 ` [PATCH 3/8] io/channel-socket: only clear O_NONBLOCK on received fds if set Tim Pambor
2026-10-26 11:29   ` Daniel P. Berrangé
2026-10-22 13:47 ` [PATCH 4/8] chardev/char-socket: detect peer close portably Tim Pambor
2026-10-22 13:47 ` [PATCH 5/8] vhost-user: enable frontends on any POSIX system Tim Pambor
2026-10-27 19:24   ` Stefan Hajnoczi
2026-10-28  8:32     ` Stefano Garzarella
2026-10-28 12:33       ` Stefan Hajnoczi
2026-10-28 13:23         ` Stefano Garzarella
2026-10-28 18:43           ` Stefan Hajnoczi
2026-10-28 19:33             ` Tim Pambor
2026-10-29  9:05               ` Stefano Garzarella
2026-10-29 12:10               ` Stefan Hajnoczi
2026-10-22 13:47 ` [PATCH 6/8] libvhost-user: enable it " Tim Pambor
2026-10-22 13:47 ` [PATCH 7/8] contrib/vhost-user-blk: " Tim Pambor
2026-10-22 13:47 ` [PATCH 8/8] libvhost-user: detect memfd support with a link test Tim Pambor
2026-10-29 11:44   ` Stefano Garzarella [this message]
2026-10-23 16:00 ` [PATCH 0/8] vhost-user: another try at supporting any POSIX system Stefano Garzarella
2026-10-26  9:17   ` Tim Pambor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auMwF2bb4bHLLuwB@sgarzare-redhat \
    --to=sgarzare@redhat.com \
    --cc=berrange@redhat.com \
    --cc=brad@comstyle.com \
    --cc=hreitz@redhat.com \
    --cc=jasowangio@gmail.com \
    --cc=kwolf@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=pierrick.bouvier@oss.qualcomm.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rnorwitz@nvidia.com \
    --cc=timpambor@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.