From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
Cc: "Thomas Huth" <thuth@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
qemu-devel@nongnu.org, qemu-s390x@nongnu.org,
"Richard Henderson" <richard.henderson@linaro.org>,
"Matthew Rosato" <mjrosato@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Eric Farman" <farman@linux.ibm.com>,
"Chao Liu" <chao.liu@processmission.com>,
"Tyrone Ting" <kfting@nuvoton.com>,
"Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>,
"Hao Wu" <wuhaotsh@google.com>,
"Halil Pasic" <pasic@linux.ibm.com>,
qemu-arm@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH 7/8] tests/functional: remove @skipSlowTest from quanta_gsj test
Date: Thu, 29 Oct 2026 17:42:41 +0000 [thread overview]
Message-ID: <auOFkbm4VJblb4SY@redhat.com> (raw)
In-Reply-To: <ae1dada6-057c-4614-bf59-ec60b1f89604@oss.qualcomm.com>
On Thu, Oct 29, 2026 at 09:14:21AM -0800, Pierrick Bouvier wrote:
> On 10/29/2026 9:05 AM, Thomas Huth wrote:
> > On 29/10/2026 17.38, Peter Maydell wrote:
> >> On Thu, 29 Oct 2026 at 16:13, Alex Bennée <alex.bennee@linaro.org> wrote:
> >>>
> >>> The full quanta_gsj test would have caught the regression caused by
> >>> the WFxT implementation and isn't that slow (<60s) it needs to be
> >>> gated.
> >>>
> >>> Suggested-by: Thomas Huth <thuth@redhat.com>
> >>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> >>> ---
> > ...
> >> The other argument against using quanta-gsj as our test here
> >> is that as discussed as part of a recent docs update:
> >> https://lore.kernel.org/qemu-devel/20260627063208.33642-1-
> >> bin.meng@processmission.com/
> >> it's no longer supported by OpenBMC.
> >>
> >> I didn't get any response from the Nuvoton maintainers in
> >> that thread, but I kind of favour deprecating the machine
> >> type in QEMU.
> > If nobody seems to care anymore, please go ahead and mark it as
> > deprecated! We can still revert it in case someone speaks up later
> > during the deprecation period.
> >
> > Thomas
> >
> >
>
> For what it's worth, I also noticed that this test tends to timeout
> randomly, even when running tests with -j1. So we might observe this in
> our CI also, by enabling it by default.
If it is unreliable then it should be tagged with skipFlakyTest,
and a gitlab issue filed with an example failure trace.
If no one steps up to fix the flaky test in a reasonable time
then it should later be deleted, as flaky tests should not be
allowed to linger for years.
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
next prev parent reply other threads:[~2026-10-29 17:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 16:13 [PATCH 0/8] fixes for 11.2 softfreeze (checkpatch, gdbstub, wfxt, bcm fb) Alex Bennée
2026-10-29 16:13 ` [PATCH 1/8] scripts/checkpatch: validate fixes against origin/master Alex Bennée
2026-10-29 17:12 ` Pierrick Bouvier
2026-10-29 17:26 ` Alex Bennée
2026-10-29 17:44 ` Pierrick Bouvier
2026-10-29 17:49 ` Pierrick Bouvier
2026-10-29 19:22 ` Alex Bennée
2026-10-29 19:32 ` Pierrick Bouvier
2026-10-29 16:13 ` [PATCH 2/8] tests/functional: fix call to common_tuxrun_gdb Alex Bennée
2026-10-29 16:13 ` [PATCH 3/8] target/arm: hold bql when SEV sets the event_register Alex Bennée
2026-10-29 16:16 ` Richard Henderson
2026-10-29 16:13 ` [PATCH 4/8] target/arm: don't pass env to the sev helper Alex Bennée
2026-10-29 16:17 ` Richard Henderson
2026-10-29 16:13 ` [PATCH 5/8] target/arm: simplify wfxt_timer_cb to only trigger cpu_interrupt Alex Bennée
2026-10-29 16:19 ` Richard Henderson
2026-10-29 16:30 ` Peter Maydell
2026-10-29 16:13 ` [PATCH 6/8] tests/tcg: import arm wfe test cases for #4670 Alex Bennée
2026-10-29 16:13 ` [PATCH 7/8] tests/functional: remove @skipSlowTest from quanta_gsj test Alex Bennée
2026-10-29 16:38 ` Peter Maydell
2026-10-29 17:05 ` Thomas Huth
2026-10-29 17:14 ` Pierrick Bouvier
2026-10-29 17:42 ` Daniel P. Berrangé [this message]
2026-10-29 17:02 ` Thomas Huth
2026-10-29 16:13 ` [PATCH 8/8] target/arm: fix bcm2835 migration issue Alex Bennée
2026-10-29 16:24 ` Peter Maydell
2026-10-29 16:26 ` [PATCH 0/8] fixes for 11.2 softfreeze (checkpatch, gdbstub, wfxt, bcm fb) Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auOFkbm4VJblb4SY@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=borntraeger@linux.ibm.com \
--cc=chao.liu@processmission.com \
--cc=farman@linux.ibm.com \
--cc=kfting@nuvoton.com \
--cc=mjrosato@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@oss.qualcomm.com \
--cc=pierrick.bouvier@oss.qualcomm.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
--cc=wuhaotsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.