All of lore.kernel.org
 help / color / mirror / Atom feed
From: Taylor Blau <ttaylorr@openai.com>
To: Pia Park <pia@pierre.co>
Cc: git@vger.kernel.org, Taylor Blau <me@ttaylorr.com>,
	Derrick Stolee <stolee@gmail.com>
Subject: Re: [PATCH v3] midx-write: skip writes with no object entries
Date: Thu, 29 Oct 2026 15:31:44 -0500	[thread overview]
Message-ID: <auOtMGiGOvWVtkl7@com-79390> (raw)
In-Reply-To: <97eca05600afc5828e3f27c6fcfd3f7872ca326b.1793260625.git.pia@pierre.co>

On Thu, Oct 29, 2026 at 01:26:17AM -0700, Pia Park wrote:
>  midx-write.c                            |  5 +--
>  t/t5319-multi-pack-index.sh             | 15 +++++++
>  t/t5326-multi-pack-bitmaps.sh           |  9 ++---
>  t/t5334-incremental-multi-pack-index.sh | 52 +++++++++++++++++++++++++
>  4 files changed, 72 insertions(+), 9 deletions(-)

Thanks, this version looks good to me. I agree that the remaining set of
questions can be dealt with outside of this series. Thanks for working
on this, Pia!

Thanks,
Taylor

  reply	other threads:[~2026-10-29 20:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-08  1:46 [PATCH] midx-write: skip empty incremental layers Pia Park
2026-09-08  4:09 ` Taylor Blau
2026-09-08  7:10   ` [PATCH v2] midx-write: skip writes with no object entries Pia Park
2026-09-08 15:06     ` Taylor Blau
     [not found]       ` <CAOWp8q6uCcVL-0cLxvf-ncydSiapheYTDnFhom3CnKiMWyfJ=w@mail.gmail.com>
2026-09-15 14:25         ` Pia Park
2026-10-27 22:05           ` Junio C Hamano
2026-10-28  0:39             ` Taylor Blau
2026-10-29  8:26     ` [PATCH v3] " Pia Park
2026-10-29 20:31       ` Taylor Blau [this message]
2026-10-29 20:50         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auOtMGiGOvWVtkl7@com-79390 \
    --to=ttaylorr@openai.com \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    --cc=pia@pierre.co \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.