Re: [PATCH v5 05/13] arm: dts: shikra: retain QUP SPL dependencies

[Sumit Garg <sumit.garg@kernel.org>]

Hey Abhilash, Aswin, Balaji, Varda,

Just wanted to reiterate the general OF_UPSTREAM DT guideline below.

On Thu, 29 Oct 2026 at 10:51:38 -0600, Tom Rini wrote:
>On Thu, Oct 29, 2026 at 03:57:38AM -0700, Abhilash V wrote:
>
>> Retain QUP, console, pinctrl, clock, power-domain, RPM,
>> and MMC dependencies in the SPL device tree so the firmware
>> loader can use the boot medium once probed in SPL.
>>
>> Signed-off-by: Abhilash V <abhilash.v@oss.qualcomm.com>
>> ---
>>  arch/arm/dts/shikra-cqs-evk-u-boot.dtsi | 44 +++++++++++++++++++++++++
>>  1 file changed, 44 insertions(+)
>>
>> diff --git a/arch/arm/dts/shikra-cqs-evk-u-boot.dtsi b/arch/arm/dts/shikra-cqs-evk-u-boot.dtsi
>> index e807b91ef1f..c79c63ad732 100644
>> --- a/arch/arm/dts/shikra-cqs-evk-u-boot.dtsi
>> +++ b/arch/arm/dts/shikra-cqs-evk-u-boot.dtsi
>> @@ -20,3 +20,47 @@
>>  &usb_qmpphy {
>>  	status = "okay";
>>  };
>> +
>> +/*
>> + * Keep SPL console and QUP dependencies.
>> + */
>> +&gcc {
>> +	bootph-all;
>> +};
>> +
>> +&tlmm {
>> +	bootph-all;
>> +};
>> +
>> +&qup_uart0_default {
>> +	bootph-all;
>> +};
>> +
>> +&sdc1_state_on {
>> +	bootph-all;
>> +};
>> +
>> +&sdc1_state_off {
>> +	bootph-all;
>> +};
>> +
>> +&sdhc_1 {
>> +	bootph-all;
>> +};
>> +
>> +&qupv3_0 {
>> +	bootph-all;
>> +};
>> +
>> +&uart0 {
>> +	bootph-all;
>> +};
>> +
>> +/* Retain the RPM clock and power-domain providers for boot consumers. */
>> +&rpmcc {
>> +	bootph-all;
>> +};
>> +
>> +&rpmpd {
>> +	bootph-all;
>> +};
>
>Why aren't you upstreaming these?

+1

Please don't push any DT overrides in U-Boot without any upstream path
to get rid of DT overrides in future. Always provide a link to upstream
kernel DT posting whenever any exception is needed to add DT overrides
in U-Boot. This applies to all the patch-sets adding DT overrides
especially in case of U-Boot SPL support series.

bootph-all is well upstream kernel DT accepted approach, so first go for
kernel DT updates always.

-Sumit