Re: [PATCH v2 2/2] KVM: arm64: Remove stale remark on canonical IPA alignment

[Leonardo Bras <leo.bras@arm.com>]

On Thu, Oct 29, 2026 at 05:52:38PM +0000, Wei-Lin Chang wrote:
> Commit 3b8ce2b5132ae ("KVM: arm64: Use a variable for the canonical IPA
> in kvm_s2_fault_map()") created a variable to store the canonical IPA,
> instead of calculating it when needed. It moved the aligning just before
> mark_page_dirty_in_slot() to an earlier place but did not update the
> comment.
> 
> Remove the stale part of the comment.
> 
> Signed-off-by: Wei-Lin Chang <weilin.chang@arm.com>
> ---
>  arch/arm64/kvm/mmu.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c
> index c7df646af79f..695c6229a216 100644
> --- a/arch/arm64/kvm/mmu.c
> +++ b/arch/arm64/kvm/mmu.c
> @@ -2232,11 +2232,7 @@ static int kvm_s2_fault_map(const struct kvm_s2_fault_desc *s2fd,
>  	kvm_fault_unlock(kvm);
>  	kfree(mapping);
>  
> -	/*
> -	 * Mark the page dirty only if the fault is handled successfully,
> -	 * making sure we adjust the canonical IPA if the mapping size has
> -	 * been updated (via a THP upgrade, for example).
> -	 */
> +	/* Mark the page dirty only if the fault is handled successfully. */
>  	if (writable && !ret)
>  		mark_page_dirty_in_slot(kvm, s2fd->memslot,
>  					gpa_to_gfn(canonical_ipa));
> -- 
> 2.43.0
> 

Reviewed-by: Leonardo Bras <leo.bras@arm.com>