From: Jiri Olsa <olsajiri@gmail.com>
To: bot+bpf-ci@kernel.org
Cc: ast@kernel.org, daniel@iogearbox.net, bpf@vger.kernel.org,
linux-mm@kvack.org, andrii@kernel.org, eddyz87@gmail.com,
memxor@gmail.com, ljs@kernel.org, john.fastabend@gmail.com,
nierro92@gmail.com, martin.lau@kernel.org,
yonghong.song@linux.dev, mason@kernel.org,
ihor.solodrai@linux.dev
Subject: Re: [PATCH bpf-next 5/8] selftests/bpf: Test user memory mmap kfuncs
Date: Fri, 30 Oct 2026 14:08:24 +0100 [thread overview]
Message-ID: <auSWyJS1ORYApv28@krava> (raw)
In-Reply-To: <18976b63cb396cdfaebc5c630c926d88544160ef2a4c034e8a290df2b428806e@mail.kernel.org>
On Thu, Oct 29, 2026 at 09:59:31PM +0000, bot+bpf-ci@kernel.org wrote:
> > selftests/bpf: Test user memory mmap kfuncs
>
> TL;DR: Nits only: the changelog omits the kfuncs.rst documentation added by
> the patch, which may belong in another patch; also an unneeded
> <sys/personality.h> include and a never-used NULL perms path in
> check_user_mem_vma().
>
> > selftests/bpf: Test user memory mmap kfuncs
> >
> > Add BPF selftests for bpf_user_mmap and bpf_user_munmap from a
> > sleepable uprobe. Check that created mappings have the requested
> > permissions and that unmapped addresses are no longer mapped.
> >
> > Assisted-by: Codex:GPT-6
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
>
> This isn't a bug, but the changelog only describes the new selftests, while
> the patch also adds a "4.4 User memory kfuncs" section to
> Documentation/bpf/kfuncs.rst.
>
> That section documents bpf_copy_to_user() as well, which is not exercised by
> the tests added here, and it states that seccomp filters do not mediate the
> mappings made by these kfuncs.
>
> Could the kfuncs.rst section go into "bpf: Add user memory kfuncs" or a
> separate documentation patch, or at least be mentioned in this changelog?
yes, it needs to go there, will fix
jirka
next prev parent reply other threads:[~2026-10-30 13:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 21:25 [PATCH bpf-next 0/8] bpf: Add user memory kfuncs Jiri Olsa
2026-10-29 21:25 ` [PATCH bpf-next 1/8] bpf: Add __srcptr kfunc argument suffix Jiri Olsa
2026-10-29 21:49 ` Andrii Nakryiko
2026-10-30 10:50 ` Jiri Olsa
2026-10-30 16:26 ` Alexei Starovoitov
2026-10-29 21:25 ` [PATCH bpf-next 2/8] bpf: Add user memory kfuncs Jiri Olsa
2026-10-29 22:00 ` Andrii Nakryiko
2026-10-30 11:08 ` Jiri Olsa
2026-10-29 22:12 ` bot+bpf-ci
2026-10-30 13:07 ` Jiri Olsa
2026-10-30 13:08 ` Jiri Olsa
2026-10-29 21:25 ` [PATCH bpf-next 3/8] selftests/bpf: Add get_procmap_info helper Jiri Olsa
2026-10-29 21:25 ` [PATCH bpf-next 4/8] selftests/bpf: Test __srcptr kfunc arguments Jiri Olsa
2026-10-29 21:25 ` [PATCH bpf-next 5/8] selftests/bpf: Test user memory mmap kfuncs Jiri Olsa
2026-10-29 21:59 ` bot+bpf-ci
2026-10-30 13:08 ` Jiri Olsa [this message]
2026-10-29 21:25 ` [PATCH bpf-next 6/8] selftests/bpf: Test user memory page exec Jiri Olsa
2026-10-29 21:25 ` [PATCH bpf-next 7/8] selftests/bpf: Test bpf_copy_to_user kfunc Jiri Olsa
2026-10-29 21:25 ` [PATCH bpf-next 8/8] selftests/bpf: Test user memory kfunc errors Jiri Olsa
2026-10-29 21:59 ` bot+bpf-ci
2026-10-30 13:08 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auSWyJS1ORYApv28@krava \
--to=olsajiri@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bot+bpf-ci@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=ihor.solodrai@linux.dev \
--cc=john.fastabend@gmail.com \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=martin.lau@kernel.org \
--cc=mason@kernel.org \
--cc=memxor@gmail.com \
--cc=nierro92@gmail.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.