Re: [PATCH] get_maintainer: lazy load JSON::PP only when --json is used

[Oleg Nesterov <oleg@redhat.com>]

On 10/30, Joe Perches wrote:
>
> On Fri, 2026-10-30 at 23:55 +0100, Oleg Nesterov wrote:
> > > >
> > > > But why? Why make get_maintainer.pl depend on yet another module?
> > > > FYI, on my Fedora 44
> > > >
> > 	$ perl -we 'use Module::Load::Conditional qw(check_install);'
> > 	Can't locate Module/Load/Conditional.pm in @INC (you may need to install the Module::Load::Conditional module) (@INC entries checked: /usr/local/lib64/perl5/5.42 /usr/local/share/perl5/5.42 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5) at -e line 1.
> > 	BEGIN failed--compilation aborted at -e line 1.
> > >
> > > Module::Load is a core perl module since 5.10 and
> > > I think you are using a broken version of a perl installation
> > And how do you think it is broken? my laptop runs the fresh Fedora 44.
>
> It doesn't include perl-core ;)

you can blame the Fedora maintainers, not me ;)

> > I used ./scripts/get_maintainer.pl many years, almost every day, and I never
> > needed to install the additional modules. Until ("get_maintainer: add --json
> > output mode")
>
> I think that was added in Linus' 7.2 in mid August and in -next since April

Yes, I hit this problem months ago, but didn't have time to send the fix.
So I had to have "git revert 09d8b39563e84fc245d642182715a7e0e024b0f2" in my
local trees until today.

> > It's not that we disagree... Worse, we can't understand each other :(
> > Perhaps is this my fault.
>
> I don't disagree with the concept of the patch.

Great, then perhaps you can ACK my trivial patch? Then we can discuss
the possible improvements.

> I think we understand each other fine, you just care less about the
> output error message.

Yes, it is true in that I don't really care about the output error message.

But then again. This error message can only happen if JSON::PP is not
installed, and my patch doesn't make it worse?

Oleg.