Re: [Buildroot] [PATCH 1/1] package/dovecot: fix build with LibreSSL

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/dovecot: fix build with LibreSSL
Date: Sun, 1 Nov 2026 17:30:26 +0100	[thread overview]
Message-ID: <audouIxxR5_vsJNX@windsurf> (raw)
In-Reply-To: <20261101082513.1583784-1-bernd@kuhls.net>

Hello Bernd,

On Sun, Nov 01, 2026 at 09:25:13AM +0100, Bernd Kuhls wrote:

Thanks for the patches, but I don't understand them together.

> diff --git a/package/dovecot/0002-lib-dcrypt-exclude-test_sign_verify_ed448-from-Libre.patch b/package/dovecot/0002-lib-dcrypt-exclude-test_sign_verify_ed448-from-Libre.patch
> new file mode 100644
> index 0000000000..3ae624d56a
> --- /dev/null
> +++ b/package/dovecot/0002-lib-dcrypt-exclude-test_sign_verify_ed448-from-Libre.patch
> @@ -0,0 +1,46 @@
> +From 2615be988c3958104e2c86323564acc05f13e616 Mon Sep 17 00:00:00 2001
> +From: Charlie Li <git@vishwin.info>
> +Date: Fri, 23 Oct 2026 22:34:34 -0400
> +Subject: [PATCH] lib-dcrypt: exclude test_sign_verify_ed448 from LibreSSL
> +
> +Upstream: https://github.com/dovecot/core/pull/340
> +
> +[Bernd: rebased for 2.4.5]
> +Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> +---
> + src/lib-dcrypt/test-crypto.c | 4 ++++
> + 1 file changed, 4 insertions(+)
> +
> +diff --git a/src/lib-dcrypt/test-crypto.c b/src/lib-dcrypt/test-crypto.c
> +index 558c9c9724..6ed164c0f0 100644
> +--- a/src/lib-dcrypt/test-crypto.c
> ++++ b/src/lib-dcrypt/test-crypto.c
> +@@ -2007,6 +2007,7 @@ static void test_static_verify_ed448(void)
> + 	test_end();
> + }
> + 
> ++#ifndef LIBRESSL_VERSION_NUMBER
> + static void test_sign_verify_ed448(void)
> + {
> + 	const char *error = NULL;
> +@@ -2033,6 +2034,7 @@ static void test_sign_verify_ed448(void)
> + 
> + 	test_end();
> + }
> ++#endif
> + 
> + static void test_xd_keypair(struct dcrypt_keypair *pair)
> + {
> +@@ -2339,7 +2340,9 @@ int main(void)
> + 		test_static_verify_ecdsa_x962,
> + #ifdef HAVE_X25519
> + 		test_sign_verify_ed25519,
> ++#ifndef LIBRESSL_VERSION_NUMBER
> + 		test_sign_verify_ed448,
> ++#endif

So this patch changes test_sign_verify_ed448() so that the function is
not implemented nor used when LIBRESSL_VERSION_NUMBER is defined.

> +diff --git a/src/lib-dcrypt/test-crypto.c b/src/lib-dcrypt/test-crypto.c
> +index 6ed164c0f0..20371cefc5 100644
> +--- a/src/lib-dcrypt/test-crypto.c
> ++++ b/src/lib-dcrypt/test-crypto.c
> +@@ -2007,7 +2007,7 @@ static void test_static_verify_ed448(void)
> + 	test_end();
> + }
> + 
> +-#ifndef LIBRESSL_VERSION_NUMBER
> ++#ifdef SN_ED448

But then here this gets changed so that the function is now defined
when SN_ED448 is available... but why isn't this also changed in
test_xd_keypair() ?

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot