All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roman Bogorodskiy <bogorodskiy@gmail.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, marcandre.lureau@redhat.com,
	berrange@redhat.com, pierrick.bouvier@oss.qualcomm.com,
	michael.roth@amd.com, kkostiuk@redhat.com
Subject: Re: [PATCH 2/2] meson.build: fix getifaddrs() detection on illumos
Date: Mon, 2 Nov 2026 13:12:46 +0100	[thread overview]
Message-ID: <auh-OAbaZfTvMKHU@tulp> (raw)
In-Reply-To: <20261015173250.65942-3-bogorodskiy@gmail.com>

  Roman Bogorodskiy wrote:

> Currently, getifaddrs() fails to get detected on illumos
> because it requires linking with libsocket which meson
> is not doing.
> 
> Fix by adding socket to getifaddrs dependencies. This
> unlocks 'guest-network-get-interfaces' implementation
> for illumos.
> 
> Signed-off-by: Roman Bogorodskiy <bogorodskiy@gmail.com>
> ---
>  meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meson.build b/meson.build
> index 432a333f56..20407024fa 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2644,7 +2644,7 @@ config_host_data.set('CONFIG_TIMERFD', cc.has_function('timerfd_create'))
>  config_host_data.set('CONFIG_GETLOADAVG', cc.has_function('getloadavg'))
>  config_host_data.set('CONFIG_ARPA_INET_64', cc.has_function('htonll'))
>  config_host_data.set('HAVE_COPY_FILE_RANGE', cc.has_function('copy_file_range'))
> -config_host_data.set('HAVE_GETIFADDRS', cc.has_function('getifaddrs'))
> +config_host_data.set('HAVE_GETIFADDRS', cc.has_function('getifaddrs', dependencies: socket))
>  config_host_data.set('HAVE_GLIB_WITH_SLICE_ALLOCATOR', glib_has_gslice)
>  config_host_data.set('HAVE_OPENPTY', cc.has_function('openpty', dependencies: util))
>  config_host_data.set('HAVE_STRCHRNUL', cc.has_function('strchrnul', prefix: osdep_prefix))
> -- 
> 2.55.0
> 

ping? (for meson.build changes)


  reply	other threads:[~2026-11-02 12:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15 17:32 [PATCH 0/2] qga: illumos fixes Roman Bogorodskiy
2026-10-15 17:32 ` [PATCH 1/2] qga: fix build on illumos Roman Bogorodskiy
2026-10-28  8:58   ` Kostiantyn Kostiuk
2026-10-28 11:51     ` Roman Bogorodskiy
2026-10-28 11:56       ` Kostiantyn Kostiuk
2026-10-15 17:32 ` [PATCH 2/2] meson.build: fix getifaddrs() detection " Roman Bogorodskiy
2026-11-02 12:12   ` Roman Bogorodskiy [this message]
2026-11-11 13:41 ` [PATCH 0/2] qga: illumos fixes Roman Bogorodskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auh-OAbaZfTvMKHU@tulp \
    --to=bogorodskiy@gmail.com \
    --cc=berrange@redhat.com \
    --cc=kkostiuk@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=michael.roth@amd.com \
    --cc=pbonzini@redhat.com \
    --cc=pierrick.bouvier@oss.qualcomm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.