All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Harald Nordgren <haraldnordgren@gmail.com>
Cc: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>,
	Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org, "D. Ben Knoble" <ben.knoble@gmail.com>,
	GGG <gitgitgadget@gmail.com>
Subject: Re: [PATCH v3] object-name: explain why <rev>~N fails in a shallow clone
Date: Mon, 2 Nov 2026 13:24:54 +0100	[thread overview]
Message-ID: <auiBFhXI_xiBTPbg@pks.im> (raw)
In-Reply-To: <CAHwyqnUP_aeKSwj03be0PVdqLX=UYhwW22kBtoWU9Oy2XoaFLA@mail.gmail.com>

On Mon, Nov 02, 2026 at 12:07:29PM +0100, Harald Nordgren wrote:
> > > Is it possible that maybe the review process needs to change if too
> > > many things are getting stuck?
> >
> > The regular reviewers have been talking about review work being scarce
> > compared to contributions (contributor work) for at least several years
> > now. How can this be changed if there simply aren’t enough people to
> > review everything?
> 
> We can loosen the requirements on perfect code, as long as it does
> what it's supposed to and doesn't have security backdoors.
> 
> Many things like tests, leaks and linting are already handled
> automatically by GitHub CI. It's a good time investment to automate
> more, because it frees up resources long-term.

Even if we automate more of it, that would still not fix our bottleneck.
I do no trust automated reviews enough to just merge patches without a
human review, as part of the review is also the conceptual direction
that we are moving towards. And that can only really be reviewed by
someone who is familiar with the project overall.

Now automation could of course still help us. For example, if
contributors started to self-review their patch series before sending
them out, or if we had a tool like Sashiko [1]. If so, the human review
would happen on a patch series that is in a better shape already, and
that would likely require less of a time investment overall.

Granted, at times we err too much on the side of polishing the last tiny
nits. But quite often that's also us trying to train newcomers to write
proper commit histories in the first place.

What I would very much like to avoid is reducing our standards just
because "carving in to AI is inevitable". I've heard that argument way
too often by now, and I don't think that it's a reasonable stance to
have. It is very much not "inevitable" that a project must move faster.

Patrick

[1]: https://sashiko.dev/

  reply	other threads:[~2026-11-02 12:25 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-20  9:53 [PATCH] object-name: explain why <ref>~N fails in a shallow clone Harald Nordgren via GitGitGadget
2026-09-20 21:59 ` D. Ben Knoble
2026-09-21 16:50 ` Junio C Hamano
2026-09-21 22:17   ` Harald Nordgren
2026-09-21 23:00     ` Junio C Hamano
2026-09-22 13:38 ` [PATCH v2] shallow: advise when a walk stops at a shallow boundary Harald Nordgren via GitGitGadget
2026-09-22 21:20   ` Junio C Hamano
2026-09-23 18:55 ` [PATCH v3] object-name: explain why <rev>~N fails in a shallow clone Harald Nordgren via GitGitGadget
2026-11-02  9:21   ` Junio C Hamano
2026-11-02 10:06     ` Harald Nordgren
2026-11-02 11:01       ` Kristoffer Haugsbakk
2026-11-02 11:07         ` Harald Nordgren
2026-11-02 12:24           ` Patrick Steinhardt [this message]
2026-11-02 12:44             ` Kristoffer Haugsbakk
2026-11-02 14:07             ` Harald Nordgren
2026-11-02 14:31               ` Patrick Steinhardt
2026-11-02 14:48                 ` Harald Nordgren
2026-11-02 14:36             ` Phillip Wood
2026-11-02 14:52               ` Harald Nordgren
2026-11-02 18:55               ` Junio C Hamano
2026-11-02 18:40             ` Junio C Hamano
2026-11-02 12:34           ` Kristoffer Haugsbakk
2026-11-02 14:10             ` Harald Nordgren
2026-11-02 14:33               ` Patrick Steinhardt
2026-11-02 18:35       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auiBFhXI_xiBTPbg@pks.im \
    --to=ps@pks.im \
    --cc=ben.knoble@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=haraldnordgren@gmail.com \
    --cc=kristofferhaugsbakk@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.