Re: [PATCH v15 1/4] PCI: Assume control of portdrv-related features only when portdrv enabled

[Lukas Wunner <lukas@wunner.de>]

On Mon, Nov 02, 2026 at 12:38:28PM -0800, Kuppuswamy Sathyanarayanan wrote:
> On 11/2/2026 12:20 PM, Lukas Wunner wrote:
> > This is now commit 6347fd9aee19 in Linus' tree and I think there's a problem:
[...]
> > The commit is setting the native_pcie_hotplug bit up front based on
> > CONFIG_PCIEPORTBUS.
> > 
> > But there's an if-clause at the top of get_port_device_capability() which
> > adds PCIE_PORT_SERVICE_HP to the port services used by a given PCIe port.
> > 
> > Inside the if-clause is code to disable hotplug interrupts if the BIOS
> > left them enable.
> > 
> > Since the commit, if CONFIG_PCIEPORTBUS=n, the if-clause is no longer
> > entered and so the interrupts are no longer disabled.
> 
> I don't think this case changed. get_port_device_capability() is in
> portdrv.c, which is only built with CONFIG_PCIEPORTBUS=y:
> 
>   obj-$(CONFIG_PCIEPORTBUS)	+= pcieportdrv.o bwctrl.o
> 
> So with CONFIG_PCIEPORTBUS=n, the if-clause was never entered, before or
> after this commit.

Okay, that convinces me, thanks for the explanation.

> Did you see a case where the interrupts stay enabled with this commit?

Nope, just thought "this looks fishy" when I rebased my development branch.

Thanks!

Lukas