Re: [PATCH 3/3] ASoC: cs42l43: Improve pop performance of the input power up

[Charles Keepax <ckeepax@opensource.cirrus.com>]

On Tue, Nov 03, 2026 at 09:39:43AM +0000, Charles Keepax wrote:
> On Mon, Nov 02, 2026 at 05:07:01PM +0000, Mark Brown wrote:
> > > cs42l43's decimator is particularly susceptible to discontinuities
> > > during startup. To help reduce the pop noises adjust the high
> > > pass filter settings whilst powering up the microphones and add
> > > a sizable delay to let that filter settle, then restore the user
> > > settings.
> > 
> > >  struct decim_info cs42l43_decim_info[] = {
> > >  	{
> > > +		.freg = CS42L43_DECIM_HPF_WNF_CTRL1,
> > >  		.vreg = CS42L43_DECIM_VOL_CTRL_CH1_CH2,
> > >  		.vmask = CS42L43_DECIM1_VD_RAMP_MASK | CS42L43_DECIM1_MUTE_MASK,
> > >  	},
> > >  	{
> > > +		.freg = CS42L43_DECIM_HPF_WNF_CTRL1,
> > >  		.vreg = CS42L43_DECIM_VOL_CTRL_CH1_CH2,
> > >  		.vmask = CS42L43_DECIM2_VD_RAMP_MASK | CS42L43_DECIM2_MUTE_MASK,
> > >  	},
> > >  	{
> > > +		.freg = CS42L43_DECIM_HPF_WNF_CTRL2,
> > >  		.vreg = CS42L43_DECIM_VOL_CTRL_CH1_CH2,
> > >  		.vmask = CS42L43_DECIM1_VD_RAMP_MASK | CS42L43_DECIM1_MUTE_MASK,
> > >  	},
> > 
> > Sashiko is flagging a bunch of concerns about the accuracy of this
> > table:
> > 
> >    https://sashiko.dev/#/patchset/20261102155440.3995136-1-ckeepax%40opensource.cirrus.com
> 
> Yeah replied on the list about that, the table is fine, as the
> input is muxed. But the other two comments are good so will send
> a v2 with those fixed up shortly.

Although looking more closely maybe not, will check in a bit more
detail :-)

Thanks,
Charles