All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, hreitz@redhat.com,
	jean-louis@dupond.be, den@openvz.org
Subject: Re: [PATCH 1/3] iotests/290: add test case to check 'discard-no-unref' option behavior
Date: Tue, 3 Nov 2026 16:53:46 +0100	[thread overview]
Message-ID: <auoDiqgIluYOUr9F@redhat.com> (raw)
In-Reply-To: <20261027104441.830212-2-andrey.drobyshev@virtuozzo.com>

Am 27.10.2026 um 11:44 hat Andrey Drobyshev geschrieben:
> We basically fill 2 images with identical data and perform discard
> operations with and without 'discard-no-unref' enabled.  Then we check
> that images still read identically, that their disk usage is the same
> (i.e. fallocate(FALLOC_FL_PUNCH_HOLE|FALLOC_FL_KEEP_SIZE) is called for
> both) and that with the option enabled cluster is still marked as
> allocated in "qemu-img map" output.  We also check that the option
> doesn't work with qcow2 v2 images.
> 
> Signed-off-by: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
> Reviewed-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
> Reviewed-by: Alberto Garcia <berto@igalia.com>

This test fails with -fuse:

$ tests/qemu-iotests/check -fuse -qcow2 290
[...]
290   fail       [16:49:10] [16:49:16]   5.3s                 output mismatch (see /home/kwolf/source/qemu/build-clang/scratch/qcow2-fuse-290/290.out.bad)
--- /home/kwolf/source/qemu/tests/qemu-iotests/290.out
+++ /home/kwolf/source/qemu/build-clang/scratch/qcow2-fuse-290/290.out.bad
@@ -77,7 +77,7 @@
 discard 65536/65536 bytes at offset 65536
 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 # Compare disk usage of the 2 images
-disk_usage(t.qcow2) - disk_usage(t.qcow2.nounref) = 0
+disk_usage(fuse-t.qcow2) - disk_usage(fuse-t.qcow2.nounref) = 0
 # Check that images are still identical
 Images are identical.
 # Output of qemu-img map for the image with dropped reference
Failures: 290
Failed 1 of 1 iotests

Kevin



  parent reply	other threads:[~2026-11-03 15:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-27 10:44 [PATCH 0/3] qcow2: fix discard-no-unref=on data corruption Andrey Drobyshev
2026-10-27 10:44 ` [PATCH 1/3] iotests/290: add test case to check 'discard-no-unref' option behavior Andrey Drobyshev
2026-10-29 14:58   ` Jean-Louis Dupond
2026-11-05 15:59     ` Andrey Drobyshev
2026-11-03 15:53   ` Kevin Wolf [this message]
2026-11-05 15:59     ` Andrey Drobyshev
2026-10-27 10:44 ` [PATCH 2/3] qcow2: fix snapshot data corruption with discard-no-unref=on Andrey Drobyshev
2026-10-29 14:58   ` Jean-Louis Dupond
2026-11-03 16:06     ` Kevin Wolf
2026-11-05 16:00       ` Andrey Drobyshev
2026-10-27 10:44 ` [PATCH 3/3] iotests/290: add 'discard' and 'write -z -u' case with a snapshot Andrey Drobyshev
2026-10-27 11:39 ` [PATCH 0/3] qcow2: fix discard-no-unref=on data corruption Denis V. Lunev
2026-11-03 16:07 ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auoDiqgIluYOUr9F@redhat.com \
    --to=kwolf@redhat.com \
    --cc=andrey.drobyshev@virtuozzo.com \
    --cc=den@openvz.org \
    --cc=hreitz@redhat.com \
    --cc=jean-louis@dupond.be \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.