From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Prashanth K <prashanth.k@oss.qualcomm.com>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
Subject: Re: [PATCH v3] usb: dwc3: qcom: check for hcd in dwc3_qcom_read_usb2_speed
Date: Wed, 4 Nov 2026 02:14:20 +0000 [thread overview]
Message-ID: <auqUaK406nZJNIzX@vbox> (raw)
In-Reply-To: <20261022052602.2335652-1-prashanth.k@oss.qualcomm.com>
On Thu, Oct 22, 2026, Prashanth K wrote:
> Currently dwc->xhci is not cleared if xhci_plat_probe() fails. During
> system suspend, dwc3_qcom_read_usb2_speed() checks dwc->xhci and assumes
> xhci is initialised. Since the probe failed, hcd will be null, and the
> subsequent access results in a NULL pointer dereference
>
> Unable to handle kernel NULL pointer dereference at
> virtual address 0000000000000058
>
> Call trace:
> dwc3_qcom_pm_suspend
> dpm_run_callback
> device_suspend
> dpm_suspend
> dpm_suspend_start
> suspend_devices_and_enter
> pm_suspend
>
> Explicitly check the hcd pointer in dwc3_qcom_read_usb2_speed
> before accessing it.
>
> Fixes: 6895ea55c385 ("usb: dwc3: qcom: Configure wakeup interrupts during suspend")
> Signed-off-by: Prashanth K <prashanth.k@oss.qualcomm.com>
> ---
Can we add Cc stable?
Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Thanks,
Thinh
prev parent reply other threads:[~2026-11-04 2:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 5:26 [PATCH v3] usb: dwc3: qcom: check for hcd in dwc3_qcom_read_usb2_speed Prashanth K
2026-10-22 5:33 ` sashiko-bot
2026-10-22 7:37 ` Peter Chen
2026-11-04 2:14 ` Thinh Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auqUaK406nZJNIzX@vbox \
--to=thinh.nguyen@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=krishna.kurapati@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=prashanth.k@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.