From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] repo_config_values: freeze the structure for now
Date: Wed, 4 Nov 2026 07:36:21 +0100 [thread overview]
Message-ID: <aurSZcNENBrgxowu@pks.im> (raw)
In-Reply-To: <xmqq1p917kwl.fsf@gitster.g>
On Tue, Nov 03, 2026 at 11:52:10AM -0800, Junio C Hamano wrote:
> The configuration and settings per repository is currently in an
> unfortunate mess. Especially given that repo_config_values() cannot
> work on any repository instance other than the_repository, moving
> more members into this structure is unwelcome.
>
> Acked-by: Patrick Steinhardt <ps@pks.im>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
You already got my Acked-by, but let me state explicitly that I'm happy
with this change. Thanks!
Patrick
next prev parent reply other threads:[~2026-11-04 6:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 19:52 [PATCH] repo_config_values: freeze the structure for now Junio C Hamano
2026-11-04 6:36 ` Patrick Steinhardt [this message]
2026-11-04 16:13 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aurSZcNENBrgxowu@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.