All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: Richard Fitzgerald <rf@opensource.cirrus.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	linux-sound@vger.kernel.org, patches@opensource.cirrus.com
Subject: Re: [PATCH] ASoC: codecs: madera: release runtime PM ref on FLL config failure
Date: Wed, 4 Nov 2026 11:00:09 +0000	[thread overview]
Message-ID: <ausQOTONkoBIqYrf@opensource.cirrus.com> (raw)
In-Reply-To: <20261104022814.1484284-1-vulab@iscas.ac.cn>

On Wed, Nov 04, 2026 at 02:28:14AM +0000, Wentao Liang wrote:
> When the FLL is not already enabled, madera_fllhj_enable() takes a
> runtime PM reference and relies on madera_fllhj_disable() to drop it
> later. If madera_fllhj_apply() fails, the ENA bit is never set, so a
> subsequent disable sees no change and does not drop the reference,
> leaking it along with the device's active state.
> 
> Drop the reference on the failure path and skip waiting for a lock that
> will never be asserted.
> 
> Fixes: 6535e831b4c8 ("ASoC: cs47l92: Add codec driver for Cirrus Logic CS47L92")
> Cc: stable@vger.kernel.org
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---

Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles

  parent reply	other threads:[~2026-11-04 11:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04  2:28 [PATCH] ASoC: codecs: madera: release runtime PM ref on FLL config failure Wentao Liang
2026-11-04  2:42 ` sashiko-bot
2026-11-05 11:11   ` Richard Fitzgerald
2026-11-04 11:00 ` Charles Keepax [this message]
2026-11-05  0:44 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ausQOTONkoBIqYrf@opensource.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-sound@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=rf@opensource.cirrus.com \
    --cc=tiwai@suse.com \
    --cc=vulab@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.