Re: [PATCH] platform/x86: TPMI: clean up CPU mappings on offline

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Wed, Nov 04, 2026 at 11:27:24AM +0800, lirongqing wrote:
> 
> The TPMI power domain driver adds each online CPU to a hash table and
> its power domain mask, but does not remove either entry when the CPU
> goes offline. Bringing a CPU back online can therefore insert the same
> hlist node again and leave stale CPU mask state.
> 
> Register an offline callback that removes the hash entry and clears the
> CPU from its power domain mask.

...

> +static int tpmi_cpu_offline(unsigned int cpu)
> +{
> +	struct tpmi_cpu_info *info = &per_cpu(tpmi_cpu_info, cpu);
> +	int index;
> +
> +	if (hlist_unhashed(&info->hnode) || !tpmi_domain_is_valid(info))
> +		return 0;
> +
> +	index = info->pkg_id * MAX_POWER_DOMAINS + info->punit_domain_id;
> +
> +	guard(mutex)(&tpmi_lock);

+ Blank line, so we can see at glance the lock usage.

No need to resend just for this, unless Ilpo asks for it.

> +	cpumask_clear_cpu(cpu, &tpmi_power_domain_mask[index]);
> +	hash_del(&info->hnode);
> +
> +	return 0;
> +}

-- 
With Best Regards,
Andy Shevchenko