From: Justin Tobler <jltobler@gmail.com>
To: Kristofer Karlsson <krka@spotify.com>
Cc: Patrick Steinhardt <ps@pks.im>,
Kristofer Karlsson via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH v2] odb: do not list our own refs as alternate refs in the quarantine
Date: Wed, 4 Nov 2026 10:58:12 -0600 [thread overview]
Message-ID: <autiszIPCf4Aes9T@denethor> (raw)
In-Reply-To: <CAL71e4M0t2ZgbqOd4MXeX3vH2W7pPRSMg+8i8epXYbh5-5t8Hw@mail.gmail.com>
On 26/11/04 11:32AM, Kristofer Karlsson wrote:
> I agree with that long-term direction. What do you think we should
> do for the short term? I see a few options:
> 1. A smaller, more focused patch in the alternate refs code, as Peff
> suggested in the other message.
> 2. Your read-only transaction environment for the connectivity check,
> (if you want to take that on, I would probably mess it up :-) ).
> 3. Only a regression test for now, with the hidden refs case marked as
> test_expect_failure, so that we do not lose track of it.
> 4. Or nothing, and wait for the long-term fix, as nobody seems to be
> hit hard by this at the moment.
IMO, I think the patch suggested by Peff is a reasonably fix for this
problem. Later down the line I will probably also revisit how "files"
ODB transactions manage the object directory, but there are some other
transaction related topics I'm hoping to land first.
Thanks,
-Justin
next prev parent reply other threads:[~2026-11-04 16:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 15:18 [PATCH] odb: do not list our own refs as alternate refs in the quarantine Kristofer Karlsson via GitGitGadget
2026-10-29 16:57 ` Justin Tobler
2026-10-30 11:29 ` Kristofer Karlsson
2026-10-29 17:24 ` Junio C Hamano
2026-10-30 11:51 ` Kristofer Karlsson
2026-10-30 16:05 ` Junio C Hamano
2026-10-30 18:17 ` Jeff King
2026-11-02 11:45 ` [PATCH v2] " Kristofer Karlsson via GitGitGadget
2026-11-03 0:37 ` Junio C Hamano
2026-11-03 1:12 ` Junio C Hamano
2026-11-03 10:19 ` Kristofer Karlsson
2026-11-03 11:00 ` Patrick Steinhardt
2026-11-03 12:05 ` Kristofer Karlsson
2026-11-03 12:26 ` Patrick Steinhardt
2026-11-03 21:53 ` Justin Tobler
2026-11-04 10:32 ` Kristofer Karlsson
2026-11-04 16:58 ` Justin Tobler [this message]
2026-11-04 2:48 ` Jeff King
2026-11-04 10:25 ` Kristofer Karlsson
2026-11-04 18:05 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=autiszIPCf4Aes9T@denethor \
--to=jltobler@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=krka@spotify.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.